Skip to content

[ISSUE #4770] Empty class member cause NullpointerException #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 6 commits into from
Feb 20, 2024
Merged

[ISSUE #4770] Empty class member cause NullpointerException #4777

mxsm merged 6 commits into from
Feb 20, 2024

Conversation

@scwlkq
Copy link
Contributor

@scwlkq scwlkq commented Feb 20, 2024 •
edited
Loading

Contribution Checklist

Fixes #4770

Motivation

Modifications

  1. 对writeOffset增加了对null的兼容
  2. 删除了CloudEventUtil的注释（ // todo: recordPartition & recordOffset）因为openconnect模块实现了connector的offset相关。 这个注释的日期是23年8月 openconnect-offset是23年7月，或者说CloudEventUtil需要实现不同中间件offset的转化？

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

mxsm
mxsm approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 1a5e06c into apache:master Feb 20, 2024
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@scwlkq
[ISSUE apache#4770] Empty class member cause NullpointerException (ap…
48a1284 
…ache#4777)

* Add null check in writeOffset method

* delete todo

* Move data.put inside null check in writeOffset method

* simplify if judgement

* remove dev environment

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

[Bug] Empty class member cause NullpointerException

4 participants

@scwlkq @mxsm @Pil0tXia @xwm1992