Skip to content

[ISSUE #4095] Code Optimization and Interrupted Exception handling.[EtcdCustomService] #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 4 commits into from
Jan 20, 2024
Merged

[ISSUE #4095] Code Optimization and Interrupted Exception handling.[EtcdCustomService] #4752

mxsm merged 4 commits into from
Jan 20, 2024

Conversation

@scwlkq
Copy link
Contributor

@scwlkq scwlkq commented Jan 20, 2024 •
edited
Loading

Fixes #4095 .

Motivation

Code Optimization and Interrupted Exception handling in EtcdCustomService.class

Modifications

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia
Copy link
Member

Pil0tXia commented Jan 20, 2024

Please correct typos in PR title.

@scwlkq scwlkq changed the title [ISSSUE #4095] Code Optimization and Interrupeted Exception handling.[EtcdCustomService] [ISSUE #4095] Code Optimization and Interrupeted Exception handling.[EtcdCustomService] Jan 20, 2024
@Pil0tXia
Copy link
Member

Pil0tXia commented Jan 20, 2024

Please fix checkstyle warnings. You may read contribution guidelines to get code lints in your IDE.

Pil0tXia
Pil0tXia approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scwlkq scwlkq requested a review from Pil0tXia January 20, 2024 12:22
@Pil0tXia Pil0tXia requested a review from Alonexc January 20, 2024 12:25
mxsm
mxsm approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 39c8293 into apache:master Jan 20, 2024
@scwlkq scwlkq changed the title [ISSUE #4095] Code Optimization and Interrupeted Exception handling.[EtcdCustomService] [ISSUE #4095] Code Optimization and Interrupted Exception handling.[EtcdCustomService] Jan 20, 2024
@Pil0tXia Pil0tXia mentioned this pull request Jan 20, 2024
Closed
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@scwlkq
[ISSUE apache#4095] Code Optimization and Interrupeted Exception hand…
08bfe66 
…ling.[EtcdCustomService] (apache#4752)

* Enhance thread handling of InterruptedException

* inline variable

* check code style

* catch InterruptedException in a separate catch code block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

@Alonexc Alonexc Awaiting requested review from Alonexc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

[Enhancement] Code optimization. [EtcdCustomService]

4 participants

@scwlkq @Pil0tXia @mxsm @xwm1992