Skip to content

Conversation

@kyooosukedn
Copy link
Contributor

@kyooosukedn kyooosukedn commented Jan 19, 2024

Fixes #4633 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Optimized the message body of the Rusk SDK's returned reply message

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia changed the title [ISSUE #4633]Optimize the message body of the Rust SDK's returned reply message [ISSUE #4633] Optimize the message body of the Rust SDK's returned reply message Jan 20, 2024
@Pil0tXia Pil0tXia requested a review from mxsm January 20, 2024 06:59
PbCloudEventAttributeValue {
attr: Some(PbAttr::CeString(
SubscriptionReply::SUB_TYPE.to_string(),
ProtocolKey::SUB_REPLY_MESSAGE.to_string(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make changes here.

@mxsm
Copy link
Member

mxsm commented Jan 20, 2024

@kyooosukedn
image

@xwm1992 xwm1992 merged commit 032ff80 into apache:master Jan 26, 2024
@kyooosukedn kyooosukedn deleted the 4633 branch March 27, 2024 15:03
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…ned reply message (apache#4751)

* optimized returned reply msg

* corrected the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the message body of the Rust SDK's returned reply message

3 participants