Skip to content

[ISSUE #4690] Fix Kafka Connector failed to start #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 7 commits into from
Dec 28, 2023
Merged

[ISSUE #4690] Fix Kafka Connector failed to start #4691

mxsm merged 7 commits into from
Dec 28, 2023

Conversation

@Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Dec 27, 2023 •
edited
Loading

Fixes #4690.

Motivation

#4690

Modifications

  1. Fix Failed to construct kafka consumer error
  2. Fix The session timeout is not within the range allowed by the broker error happened after the previous fix
  3. Fix wrong default bootstrap server port
  4. Increase master branch version from 1.9.0-release to 1.10.0-release
  5. Add new versions for bug issue template and remove redundant line-breaks
  6. Fix an operator log typo

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Dec 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a381ed) 17.39% compared to head (29bc413) 17.40%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #4691   +/-   ##
=========================================
  Coverage     17.39%   17.40%           
- Complexity     1759     1760    +1     
=========================================
  Files           797      797           
  Lines         29850    29850           
  Branches       2579     2579           
=========================================
+ Hits           5192     5194    +2     
+ Misses        24177    24176    -1     
+ Partials        481      480    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm
Copy link
Member

mxsm commented Dec 27, 2023

@Pil0tXia Can I create a separate pull request to address the version issue? It's recommended to handle one thing per pull request for better clarity.

@xwm1992
Copy link
Contributor

xwm1992 commented Dec 28, 2023

@Pil0tXia Can I create a separate pull request to address the version issue? It's recommended to handle one thing per pull request for better clarity.

I agree this approach, each PR should not include too many changes that are not related to the PR theme.

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Dec 28, 2023 •
edited
Loading

@mxsm @xwm1992 No problem, I have removed the change of version.

mxsm
mxsm approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit fe7bf33 into apache:master Dec 28, 2023
@Pil0tXia Pil0tXia deleted the pil0txia_bug_4690 branch January 4, 2024 05:00
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@Pil0tXia
[ISSUE apache#4690] Fix Kafka Connector failed to start (apache#4691)
07f8774 
* Fix StringDeserializer & (session.timeout.ms)/3 > heartbeat.interval.ms
https://stackoverflow.com/questions/38406298/why-cant-i-increase-session-timeout-ms

* customize timeout config

* add new versions and remove redundant line-breaks

* Increase master version

* Fix an operator log typo

* Revert "Increase master version"

This reverts commit b112290.

* Revert 'add new versions for issue template'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@mxsm mxsm mxsm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

[Bug] Kafka Connector failed to start

3 participants

@Pil0tXia @mxsm @xwm1992