[ISSUE #4686] Shell scripts should preserve LF line endings #4687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaapo
approved these changes
Dec 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4687 +/- ##
=========================================
Coverage 17.39% 17.40%
- Complexity 1759 1760 +1
=========================================
Files 797 797
Lines 29850 29850
Branches 2579 2579
=========================================
+ Hits 5192 5194 +2
+ Misses 24177 24176 -1
+ Partials 481 480 -1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@xwm1992 PTAL~ |
3 tasks
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…ache#4687) * crlf2lf * convert sh only * write easily * Some doc optimization * minor code change * add future win scrpts * add license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4686.
Motivation
#4686
Modifications
When cloning a repository with Git on Windows, all text files with Unix-style LF line endings are replaced with Windows-style CRLF line endings, including shell scripts that require LF line endings.
By using
.gitattributes, the original LF line endings of shell scripts can be preserved, avoiding the need for secondary conversion when using WSL/Docker Desktop, and enabling developers to build binary packages/Docker images on Windows that can run on Linux systems.Reference: https://code.visualstudio.com/docs/remote/troubleshooting#_resolving-git-line-ending-issues-in-wsl-resulting-in-many-modified-files
To apply the changes, a re-clone is needed.
By the way, some minor doc and code optimization were applied.
Documentation