Skip to content

[ISSUE #4677] tcp codec enhancement #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 1 commit into from
Dec 22, 2023
Merged

[ISSUE #4677] tcp codec enhancement #4678

mxsm merged 1 commit into from
Dec 22, 2023

Conversation

@karsonto
Copy link
Member

@karsonto karsonto commented Dec 19, 2023

Fixes #4677

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (958b041) 17.28% compared to head (aa5c2bf) 17.39%.
Report is 15 commits behind head on master.

Files Patch % Lines
...che/eventmesh/common/protocol/tcp/codec/Codec.java 0.00% 7 Missing ⚠️
.../apache/eventmesh/client/tcp/common/TcpClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4678      +/-   ##
============================================
+ Coverage     17.28%   17.39%   +0.11%     
- Complexity     1742     1760      +18     
============================================
  Files           792      797       +5     
  Lines         29703    29801      +98     
  Branches       2567     2578      +11     
============================================
+ Hits           5134     5184      +50     
- Misses        24095    24137      +42     
- Partials        474      480       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xwm1992 xwm1992 changed the title [Enhancement] tcp codec enhancement [ISSUE #4677] tcp codec enhancement Dec 19, 2023
@karsonto karsonto requested a review from Pil0tXia December 20, 2023 02:08
@mxsm mxsm merged commit 2989941 into apache:master Dec 22, 2023
@karsonto karsonto deleted the develop-codec-enhancemant branch December 22, 2023 09:24
@pandaapo pandaapo mentioned this pull request Jan 1, 2024
Merged
@mxsm mxsm mentioned this pull request Jan 1, 2024
Closed
3 tasks
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@karsonto
[ISSUE apache#4677]netty codec enhancement (apache#4678)
47912b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

@Pil0tXia Pil0tXia Awaiting requested review from Pil0tXia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

[Enhancement] Tcp Codec enhancement

5 participants

@karsonto @mxsm @pandaapo @Pil0tXia @xwm1992