[ISSUE #4670] Docker build failed due to a low JDK version #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
force-pushed
the
pi0txia_bug_4670
branch
from
63c5db3 to
5bd25b7
Compare
Member
Author
|
Docker image can be tested by |
Pil0tXia
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4675 +/- ##
=========================================
Coverage 17.39% 17.39%
- Complexity 1759 1760 +1
=========================================
Files 797 797
Lines 29795 29795
Branches 2578 2578
=========================================
+ Hits 5182 5184 +2
+ Misses 24132 24131 -1
+ Partials 481 480 -1 ☔ View full report in Codecov by Sentry. |
xwm1992
approved these changes
Dec 19, 2023
pandaapo
approved these changes
Dec 19, 2023
pandaapo
changed the title
2 tasks
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…ache#4675) * Switch jdk8 to jre11 * Locate Java executable, check version and apply distinguished vm options https://docs.oracle.com/javase/9/tools/java.htm#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5__CONVERTGCLOGGINGFLAGSTOXLOG-A5046BD1 * Streamline further * minor: Adjust port seq * minor: Streamline a little * Redirect GC logs to log file instead of stdout * Streamline EVENTMESH_LOG_HOME & XLOG_PARAM * Use multi-stage compiled JRE8 env by default * fix: get pid correctly in docker * Generate pid file exactly under /bin * exec builder_8 exactly after builder_11 * Use JDK instead of JRE * Rename dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4670.
Motivation
https://github.com/Pil0tXia/eventmesh/actions/runs/7238476046/job/19719334574
Modifications
Switch builder JDK version from jdk8 to jdk11 and switch container JDK version from jdk8 to jre11.Compile the code in two stages using JDK11 and JDK8, and run the container in a Java8 environment. Optionally, provide a script for running in a Java11 environment.Using JRE instead of JDK as a runtime envrionment can reduce 300MB+ imgae size.start.shto support selecting an available version between Java 8 and Java 11, and set the VM options accordingly.get_pidfunctionality in docker.Docker deployment & compilation documents will be updated later.
Tests
These runtime environments are tested:
Generated files were added:
Connectors or Jdbc Connector are not tested.
Using Java 11:
Using Java 8:
Documentation