[ISSUE #4663] Add documentation for wecom sink connector. #4664
Conversation
| 2. 启用 sinkConnector 并检查 `sink-config.yml`。 | ||
| 3. 向 eventmesh 发送带有在 `pubSubConfig.subject` 中定义的主题消息。 | ||
| ```yaml |
There was a problem hiding this comment.
The translation of the third point is not quite smooth. Can it be "使用在pubSubConfig.subject中指定的Topic，向EventMesh发送消息。"?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4664 +/- ##
=========================================
Coverage 17.39% 17.39%
Complexity 1758 1758
=========================================
Files 797 797
Lines 29787 29787
Branches 2575 2575
=========================================
Hits 5180 5180
Misses 24129 24129
Partials 478 478 ☔ View full report in Codecov by Sentry. |
| 3. send a message to eventmesh with the topic defined in `pubSubConfig.subject` | ||
| ```yaml | ||
| pubSubConfig: | ||
| meshAddress: 127.0.0.1:10000 |
There was a problem hiding this comment.
Could you change it to the following format like this document? This may be clearer.
能否像该文档一样改成如下这样？这样也许更明确。
# default port is 10000
meshAddress: your.eventmesh.server:10000
| @@ -0,0 +1,22 @@ | |||
| # eventmesh-connector-wecom | |||
There was a problem hiding this comment.
This connector has requirements for data properties, but it seems that your document does not specify them. #4591 (comment)
该Connector对数据的属性是有要求的，您的文档好像没有说明。#4591 (comment)
| @@ -0,0 +1,22 @@ | |||
| # eventmesh-connector-slack | |||
|
|
|||
| ## SlackSinkConnector：从 eventmesh 到 slack。 | |||
There was a problem hiding this comment.
Please correct these two incorrect titles in the future. This is wecom, not slack.
Additionally, the documents (dingtalk, wecom) you wrote did not inform users as previously mentioned which attribute values are valid. It will be appreciate if you can supplement them in the future.
请在后期修改一下这两个错误的标题，这是wecom，不是slack。
另外，您写的文档（钉钉，企业微信）并没有像之前说过的那样会告知用户哪些属性值是合法的，希望您后期能够进行补充。
* Unify 'LiteMessage' to 'EventMeshMessage' * Sync connectors doc * Format RabbitMQ & 企业微信 * Format Slack & 钉钉 * Format HTTP & MongoDB * Unify 'EventMesh Runtime' * Unify 'EventMesh' * Fix translation #4664 (comment) * Explain additional attributes #4591 (comment) * Append: Unify remaining 'EventMesh' * Beautify meshAddress * Add and correct attributes
…ache#4668) * Unify 'LiteMessage' to 'EventMeshMessage' * Sync connectors doc * Format RabbitMQ & 企业微信 * Format Slack & 钉钉 * Format HTTP & MongoDB * Unify 'EventMesh Runtime' * Unify 'EventMesh' * Fix translation apache#4664 (comment) * Explain additional attributes apache#4591 (comment) * Append: Unify remaining 'EventMesh' * Beautify meshAddress * Add and correct attributes
5 participants
Fixes #4663 .
Modifications
Add documentation for wecom sink connector.