[ISSUE #4631]Optimize the message body of the Java SDK's returned reply message #4632
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4632 +/- ##
=========================================
Coverage 16.93% 16.94%
+ Complexity 1708 1707 -1
=========================================
Files 790 789 -1
Lines 29526 29498 -28
Branches 2550 2550
=========================================
- Hits 5001 4999 -2
+ Misses 24061 24034 -27
- Partials 464 465 +1 ☔ View full report in Codecov by Sentry. |
| subscriptionReply.putAllProperties(prop); | ||
|
|
||
| return CloudEvent.newBuilder(cloudEvent).putAllAttributes(reqMessageMap) | ||
| return CloudEvent.newBuilder(cloudEvent).putAllAttributes(reqMessageMap).putAllAttributes(cloudEventMap) |
There was a problem hiding this comment.
Doesn't newBuilder(cloudEvent) automatically merge the attributes (i.e., cloudEventMap) of cloudEvent here? Additionally, is prop object redundant now?
newBuilder(cloudEvent)这一步不是会自动合并cloudEvent的attributes（即cloudEventMap）吗？另外prop对象现在是不是多余的？
There was a problem hiding this comment.
Doesn't
newBuilder(cloudEvent)automatically merge the attributes (i.e.,cloudEventMap) ofcloudEventhere? Additionally, ispropobject redundant now?
newBuilder(cloudEvent)这一步不是会自动合并cloudEvent的attributes（即cloudEventMap）吗？另外prop对象现在是不是多余的？
@pandaapo Here, it is guaranteed that if there are identical properties between the returned message and the consumed message, the properties of the consumed message will be used. At the same time, I compared the version before optimization. It is also a similar operation. If the properties do not need to be overwritten, this step is not required. I keep it consistent with the version before GRPC optimization.
There was a problem hiding this comment.
if there are identical properties between the returned message and the consumed message, the properties of the consumed message will be used.
OK. Then what is role of prop?
There was a problem hiding this comment.
if there are identical properties between the returned message and the consumed message, the properties of the consumed message will be used.
OK. Then what is role of
prop?
@pandaapo I have removed it. my fault .
…ed reply message (apache#4632) * [ISSUE apache#4631]Optimize the message body of the SDK's returned reply message * optimize code, remove useless code
3 participants
Fixes #4631
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation