Skip to content

[ISSUE #4602] when wechat send message api response errcode is not zero, the wechat sink connector does not throw IllegalAccessException #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 2 commits into from
Dec 8, 2023
Merged

[ISSUE #4602] when wechat send message api response errcode is not zero, the wechat sink connector does not throw IllegalAccessException #4627

mxsm merged 2 commits into from
Dec 8, 2023

Conversation

@wizardzhang
Copy link
Contributor

@wizardzhang wizardzhang commented Dec 8, 2023

Fixes #4602.

Motivation

fix bug when wecaht api response fail

Modifications

rename org.apache.eventmesh.connector.wechat.sink.connector.TemplateMessageResponse#errocode
to org.apache.eventmesh.connector.wechat.sink.connector.TemplateMessageResponse#errcode
add abnormal test case

@pandaapo
Copy link
Member

pandaapo commented Dec 8, 2023

@wizardzhang
The content of this PR, except for eventmesh-connectors/README.md document, is the same as the final modification of #4603, right?

What does this sentence mean? #4603 (comment)

@codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c59c7f) 16.91% compared to head (5c93dc7) 16.93%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4627      +/-   ##
============================================
+ Coverage     16.91%   16.93%   +0.01%     
- Complexity     1705     1707       +2     
============================================
  Files           790      790              
  Lines         29526    29526              
  Branches       2550     2550              
============================================
+ Hits           4995     4999       +4     
+ Misses        24065    24062       -3     
+ Partials        466      465       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wizardzhang
Copy link
Contributor Author

wizardzhang commented Dec 8, 2023 •
edited
Loading

@wizardzhang The content of this PR, except for eventmesh-connectors/README.md document, is the same as the final modification of #4603, right?

What does this sentence mean? #4603 (comment)

@pandaapo yes the same as #4603, some commits used wrong email which can not link to my git hub account ,so i closed that PR and correct my email then commit again in this PR
image

@pandaapo
Copy link
Member

pandaapo commented Dec 8, 2023

Please modify this document eventmesh-connectors/README.md as before.

@wizardzhang
Copy link
Contributor Author

wizardzhang commented Dec 8, 2023

Please modify this document eventmesh-connectors/README.md as before.

OK, finished

mxsm
mxsm approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit ee9ee4c into apache:master Dec 8, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@wizardzhang
[ISSUE apache#4602] when wechat send message api response errcode is …
d090f29 
…not zero, the wechat sink connector does not throw IllegalAccessException (apache#4627)

* fix issue#4602

* change README.md file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] when wechat send message api response errcode is not zero, the wechat sink connector does not throw IllegalAccessException

3 participants

@wizardzhang @pandaapo @mxsm