Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Dec 7, 2023

Fixes #4623

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

  • Fix CloudEvents variable names do not support underscores

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8c59c7f) 16.91% compared to head (af2ec20) 16.90%.

Files Patch % Lines
...ntime/core/protocol/grpc/service/ServiceUtils.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4624      +/-   ##
============================================
- Coverage     16.91%   16.90%   -0.02%     
  Complexity     1705     1705              
============================================
  Files           790      790              
  Lines         29526    29521       -5     
  Branches       2550     2548       -2     
============================================
- Hits           4995     4991       -4     
+ Misses        24065    24062       -3     
- Partials        466      468       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrhkobe lrhkobe merged commit 67b7a9f into apache:master Dec 8, 2023
@mxsm mxsm deleted the bug-mxsm-4623 branch December 8, 2023 14:34
@xwm1992 xwm1992 added this to the 1.10 milestone Dec 12, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CloudEvents variable names do not support underscores

3 participants