Skip to content

[ISSUE #4619]Fix Grpc request reply can not receive reply message #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 3 commits into from
Dec 7, 2023
Merged

[ISSUE #4619]Fix Grpc request reply can not receive reply message #4620

xwm1992 merged 3 commits into from
Dec 7, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Dec 6, 2023

Fixes #4619

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

-Fix Grpc request reply can not revice reply message

Modifications

Describe the modifications you've done.

  • Fix Grpc request reply can not revice reply message

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (34c803b) 16.93% compared to head (650c345) 16.93%.

Files Patch % Lines
...me/core/protocol/grpc/service/ConsumerService.java 0.00% 6 Missing ⚠️
...entmesh/client/grpc/consumer/SubStreamHandler.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4620      +/-   ##
============================================
- Coverage     16.93%   16.93%   -0.01%     
+ Complexity     1693     1692       -1     
============================================
  Files           788      788              
  Lines         29420    29421       +1     
  Branches       2539     2539              
============================================
- Hits           4983     4981       -2     
- Misses        23972    23974       +2     
- Partials        465      466       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xwm1992 xwm1992 merged commit 5d8e0f2 into apache:master Dec 7, 2023
@mxsm mxsm deleted the bug-mxsm-4619 branch December 7, 2023 15:08
@xwm1992 xwm1992 added this to the 1.10 milestone Dec 12, 2023
@xwm1992 xwm1992 changed the title [ISSUE #4619]Fix Grpc request reply can not revice reply message [ISSUE #4619]Fix Grpc request reply can not receive reply message Dec 12, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@mxsm
[ISSUE apache#4619]Fix Grpc request reply can not revice reply message (
482289a 
apache#4620)

* [ISSUE apache#4619]Fix Grpc request reply can not revice reply message

* fix codestyle

* fomat codetyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@lrhkobe lrhkobe lrhkobe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Bug] Grpc request reply can not work

3 participants

@mxsm @xwm1992 @lrhkobe