[ISSUE #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] #4617
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
pandaapo
changed the title
| if (msg.getHeader().getCommand() == Command.BROADCAST_MESSAGE_TO_CLIENT) { | ||
| if (msg.getBody() instanceof EventMeshMessage) { | ||
| String body = ((EventMeshMessage) msg.getBody()).getBody(); | ||
| LogUtils.info(log, "receive message -------------------------------{}", body); |
There was a problem hiding this comment.
Please remove some unused imports, such as ReceiveMsgHook. Additionally, my suggestion is to refer to the description in the issue: change " -------------------------------" to ": ".
There was a problem hiding this comment.
Modified the suggested changes. Do I have to create another PR?
Modified changes as suggested
| if (log.isInfoEnabled()) { | ||
| log.info("receive message : {}", body); | ||
| } |
There was a problem hiding this comment.
By changing " -------------------------------" to ": ", there should not be any additional space between the word "message" and the colon ":".
Besides, why LogUtils was substituted with logger?
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Fixed codestyle. Sorry, I'm quite new to this, making a lot of mistakes at every step. Thanks for guiding
fixed codestyle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4617 +/- ##
============================================
- Coverage 16.93% 16.93% -0.01%
+ Complexity 1693 1692 -1
============================================
Files 788 788
Lines 29420 29420
Branches 2539 2539
============================================
- Hits 4983 4981 -2
- Misses 23972 23973 +1
- Partials 465 466 +1 ☔ View full report in Codecov by Sentry. |
…astSubClient] (apache#4617) * Issue Fix: apache#4088 * Issue Fix: apache#4088 Modified changes as suggested * formatted * Issue Fix: apache#4088 fixed codestyle
5 participants
Issue Fix: #4088
Replaced the anonymous inner class with a lambda expression for the handle method