[ISSUE#4590] WeCom/DingTalk connector extension supports spring environment variables #4591
Conversation
| PLAIN_TEXT("sampleText"), | ||
| MARKDOWN("sampleMarkdown"); | ||
| PLAIN_TEXT("text", "sampleText"), | ||
| MARKDOWN("markdown", "sampleMarkdown"); |
There was a problem hiding this comment.
When users want to use sinks like DingTalk or WeCom that require specific attribute values, is there a way for them to easily and clearly know which text to choose as the configuration or which attribute values can be configured? Add comments to this class and field? Or use an MD document for instructions on how to use it?
The same issue applies to specific property names defined by ConnectRecordExtensionKeys.
当用户想要使用像DingTalk或WeCom这类需要特定属性值的sink时，有没有办法让用户比较容易、比较明确地知道他们应该选择哪个文本作为配置，或者是很清楚地知道可以配置哪些属性值？在该类和字段上加注释？还是用md文档做使用说明？
对于ConnectRecordExtensionKeys定义的特定的属性名称，也是同样的问题。
There was a problem hiding this comment.
I think it is necessary to write the usage method in the md document, so that users can quickly understand how to use the connector.
我认为有必要将使用方式写在md文档中，以便用户能够快速了解如何使用。
| eventmesh.workflow.name=EVENTMESH-workflow | ||
| eventmesh.connector.dingtalkTemplateType=sampleText | ||
| eventmesh.connector.dingtalkTemplateType=text | ||
| eventmesh.connector.wecomTemplateType=text |
There was a problem hiding this comment.
Is it possible to explicitly inform the user whether the value written by the user is correct after parsing these extended fields in the configuration file?
是否可以在解析完配置文件中这些扩展字段后，显式的告知用户编写的value是否正确？
There was a problem hiding this comment.
When a user-written value is not valid, an exception will be thrown by DingDingMessageTemplateType#of.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4591 +/- ##
============================================
+ Coverage 16.79% 16.81% +0.01%
- Complexity 1677 1680 +3
============================================
Files 782 782
Lines 29317 29321 +4
Branches 2532 2532
============================================
+ Hits 4924 4930 +6
+ Misses 23933 23932 -1
+ Partials 460 459 -1 ☔ View full report in Codecov by Sentry. |
pandaapo
changed the title
* Unify 'LiteMessage' to 'EventMeshMessage' * Sync connectors doc * Format RabbitMQ & 企业微信 * Format Slack & 钉钉 * Format HTTP & MongoDB * Unify 'EventMesh Runtime' * Unify 'EventMesh' * Fix translation #4664 (comment) * Explain additional attributes #4591 (comment) * Append: Unify remaining 'EventMesh' * Beautify meshAddress * Add and correct attributes
… environment variables. (apache#4591)
…ache#4668) * Unify 'LiteMessage' to 'EventMeshMessage' * Sync connectors doc * Format RabbitMQ & 企业微信 * Format Slack & 钉钉 * Format HTTP & MongoDB * Unify 'EventMesh Runtime' * Unify 'EventMesh' * Fix translation apache#4664 (comment) * Explain additional attributes apache#4591 (comment) * Append: Unify remaining 'EventMesh' * Beautify meshAddress * Add and correct attributes
5 participants
Fixes #4590 #4567 .