[ISSUE #4581] http demo rely on tcp runtime #4583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaapo
reviewed
Nov 27, 2023
Member
pandaapo
left a comment
pandaapo
left a comment
There was a problem hiding this comment.
Does org.apache.eventmesh.grpc.sub.app.SpringBootDemoApplication also need to be processed similarly?
Contributor
Author
yes,I missed it. |
pandaapo
approved these changes
Nov 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4583 +/- ##
=========================================
Coverage 16.95% 16.95%
Complexity 1678 1678
=========================================
Files 781 781
Lines 29167 29167
Branches 2510 2510
=========================================
Hits 4945 4945
Misses 23761 23761
Partials 461 461 ☔ View full report in Codecov by Sentry. |
wizardzhang
pushed a commit
to wizardzhang/eventmesh
that referenced
this pull request
Nov 28, 2023
* fix : http demo rely on tcp runtime * fix : grpc demo rely on tcp runtime
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
* fix : http demo rely on tcp runtime * fix : grpc demo rely on tcp runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4581.
Motivation
#4581
Modifications
avoid http demo and grpc demo rely on tcp runtime
Documentation