-
Notifications
You must be signed in to change notification settings - Fork 641
[ISSUE#4580] Connector extension supports spring environment variables. #4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...t/java/org/apache/eventmesh/connector/spring/source/connector/SpringSourceConnectorTest.java
Show resolved
Hide resolved
| */ | ||
| public static String[] join(String metricName, String desc) { | ||
| return new String[] {metricName, desc}; | ||
| return new String[]{metricName, desc}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my question. Were these code format changes automatically made by Spotless? If so, does the fact that CI passed previously mean that there is a difference in the code format requirements between Spotless and Checkstyle?
这是我的疑问:这些代码格式的修改,是spotless自动修改的吗?如果是的话,因为之前CI通过了,是不是表示现在Spotless和Checkstyle对代码格式的要求有差别?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because the previous developer did not execute checkstyle, resulting in spotless not being processed successfully.
Checkstyle is a more relaxed requirement, and spotless will do more detailed formatting.
是因为之前的提交者, 没有执行过checkstyle, 导致spotless没有成功处理.
checkstyle是较为宽松的要求, spotless会做更精细化的格式化处理.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the previous developer did not execute checkstyle, resulting in spotless not being processed successfully.
I don't understand. Isn't the execution of checkstyle and the spotless independent of each other?
没明白。checkstyle的执行和spotless不是相互独立的吗?
Checkstyle is a more relaxed requirement, and spotless will do more detailed formatting.
Is there a way to make the format requirements of the two consistent?
有没有办法让两者的格式要求一致?
.../main/java/org/apache/eventmesh/connector/spring/source/connector/SpringSourceConnector.java
Outdated
Show resolved
Hide resolved
...t/java/org/apache/eventmesh/connector/spring/source/connector/SpringSourceConnectorTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4582 +/- ##
============================================
+ Coverage 16.95% 16.96% +0.01%
- Complexity 1678 1681 +3
============================================
Files 781 781
Lines 29167 29191 +24
Branches 2510 2515 +5
============================================
+ Hits 4945 4953 +8
- Misses 23761 23777 +16
Partials 461 461 ☔ View full report in Codecov by Sentry. |
…s. (apache#4582) * Connector extension supports spring environment variables. * fix: cr
…s. (apache#4582) * Connector extension supports spring environment variables. * fix: cr
Fixes #4580 .
Modifications:
CloudEventandConnectRecordextensions.