Skip to content

Conversation

@yanrongzhen
Copy link
Contributor

@yanrongzhen yanrongzhen commented Nov 27, 2023

Fixes #4580 .

Modifications:

  • Integrates spring environment properties with CloudEvent and ConnectRecord extensions.

*/
public static String[] join(String metricName, String desc) {
return new String[] {metricName, desc};
return new String[]{metricName, desc};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my question. Were these code format changes automatically made by Spotless? If so, does the fact that CI passed previously mean that there is a difference in the code format requirements between Spotless and Checkstyle?

这是我的疑问:这些代码格式的修改,是spotless自动修改的吗?如果是的话,因为之前CI通过了,是不是表示现在Spotless和Checkstyle对代码格式的要求有差别?

Copy link
Contributor Author

@yanrongzhen yanrongzhen Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because the previous developer did not execute checkstyle, resulting in spotless not being processed successfully.

Checkstyle is a more relaxed requirement, and spotless will do more detailed formatting.


是因为之前的提交者, 没有执行过checkstyle, 导致spotless没有成功处理.
checkstyle是较为宽松的要求, spotless会做更精细化的格式化处理.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the previous developer did not execute checkstyle, resulting in spotless not being processed successfully.

I don't understand. Isn't the execution of checkstyle and the spotless independent of each other?

没明白。checkstyle的执行和spotless不是相互独立的吗?

Checkstyle is a more relaxed requirement, and spotless will do more detailed formatting.

Is there a way to make the format requirements of the two consistent?

有没有办法让两者的格式要求一致?

@yanrongzhen yanrongzhen requested a review from pandaapo November 28, 2023 02:39
@codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (4e72b3c) 16.95% compared to head (f4cbecc) 16.96%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ics/prometheus/metrics/PrometheusHttpExporter.java 0.00% 35 Missing ⚠️
...spring/source/connector/SpringSourceConnector.java 28.00% 17 Missing and 1 partial ⚠️
...rics/prometheus/metrics/PrometheusTcpExporter.java 0.00% 11 Missing ⚠️
...ics/prometheus/metrics/PrometheusGrpcExporter.java 0.00% 8 Missing ⚠️
...dingtalk/sink/connector/DingDingSinkConnector.java 33.33% 2 Missing ⚠️
...rics/prometheus/utils/PrometheusExporterUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4582      +/-   ##
============================================
+ Coverage     16.95%   16.96%   +0.01%     
- Complexity     1678     1681       +3     
============================================
  Files           781      781              
  Lines         29167    29191      +24     
  Branches       2510     2515       +5     
============================================
+ Hits           4945     4953       +8     
- Misses        23761    23777      +16     
  Partials        461      461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xwm1992 xwm1992 merged commit 6508df8 into apache:master Nov 28, 2023
wizardzhang pushed a commit to wizardzhang/eventmesh that referenced this pull request Dec 1, 2023
…s. (apache#4582)

* Connector extension supports spring environment variables.

* fix: cr
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…s. (apache#4582)

* Connector extension supports spring environment variables.

* fix: cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Connector extension supports spring environment variables

3 participants