[ISSUE #3399] Make this anonymous inner class a lambda[EventMeshTcp2Client] #4575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4575 +/- ##
=========================================
Coverage 16.95% 16.96%
- Complexity 1678 1679 +1
=========================================
Files 781 781
Lines 29167 29167
Branches 2511 2511
=========================================
+ Hits 4945 4947 +2
+ Misses 23761 23760 -1
+ Partials 461 460 -1 ☔ View full report in Codecov by Sentry. |
pandaapo
approved these changes
Nov 23, 2023
Contributor
Author
|
@xwm1992 can u review the commit for me |
pandaapo
changed the title
harshithasudhakar
approved these changes
Nov 23, 2023
Closed
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3399
Motivation
make code more concise
Modifications
replace anonymous inner class with lambda.