Skip to content

[ISSUE#4570] Resolve ambiguity in method names in AbstractTCPServer #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pandaapo merged 1 commit into from
Nov 20, 2023
Merged

[ISSUE#4570] Resolve ambiguity in method names in AbstractTCPServer #4571

pandaapo merged 1 commit into from
Nov 20, 2023

Conversation

@hhuang1231
Copy link
Contributor

@hhuang1231 hhuang1231 commented Nov 20, 2023

Fixes #4570

Motivation

The method name should be changed to processTcpCommandRequest would be better

Modifications

processHttpCommandRequest method name change to processTcpCommandRequest

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

mxsm
mxsm approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandaapo pandaapo merged commit 56713fb into apache:master Nov 20, 2023
@hhuang1231 hhuang1231 deleted the fix branch November 20, 2023 09:54
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@hhuang1231
fix() : Resolve ambiguity in method names in AbstractTCPServer (apach…
dc4a581 
…e#4571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Resolve ambiguity in method names in AbstractTCPServer

3 participants

@hhuang1231 @mxsm @pandaapo