[ISSUE#4568] Support adding extensions from ConnectRcord to CloudEvent #4569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaapo
reviewed
Nov 19, 2023
.../eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4569 +/- ##
=========================================
Coverage 17.04% 17.05%
- Complexity 1667 1668 +1
=========================================
Files 766 766
Lines 28875 28875
Branches 2498 2497 -1
=========================================
+ Hits 4923 4925 +2
+ Misses 23492 23491 -1
+ Partials 460 459 -1 ☔ View full report in Codecov by Sentry. |
pandaapo
reviewed
Nov 20, 2023
.../eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
Outdated
Show resolved
Hide resolved
pandaapo
reviewed
Nov 20, 2023
...-api/src/main/java/org/apache/eventmesh/openconnect/offsetmgmt/api/data/DefaultKeyValue.java
Outdated
Show resolved
Hide resolved
pandaapo
approved these changes
Nov 20, 2023
xwm1992
approved these changes
Nov 21, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
apache#4569) * feat() : Support adding extensions from ConnectRcord to CloudEvent * feat() : Determine whether there are primitive types * fix() : Resolve ambiguity in method names in AbstractTCPServer * feat : more put and get method in KeyValue * feat : simplify Number type put method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4568.
Motivation
Support adding extensions from ConnectRcord to CloudEvent
Modifications
Improve
org.apache.eventmesh.openconnect.SourceWorker#convertRecordToEventmethodDocumentation