Skip to content

Conversation

@G-XD
Copy link
Contributor

@G-XD G-XD commented Nov 17, 2023

Fix: #4201

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@codecov
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (ebb5ba1) 16.81% compared to head (aff4211) 16.80%.

❗ Current head aff4211 differs from pull request most recent head e236ec1. Consider uploading reports for the commit e236ec1 to get more accurate results

Files Patch % Lines
...ics/prometheus/metrics/PrometheusHttpExporter.java 0.00% 36 Missing ⚠️
...rics/prometheus/metrics/PrometheusTcpExporter.java 0.00% 12 Missing ⚠️
...ics/prometheus/metrics/PrometheusGrpcExporter.java 0.00% 9 Missing ⚠️
...rics/prometheus/utils/PrometheusExporterUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4563      +/-   ##
============================================
- Coverage     16.81%   16.80%   -0.01%     
+ Complexity     1627     1626       -1     
============================================
  Files           749      749              
  Lines         28683    28682       -1     
  Branches       2487     2487              
============================================
- Hits           4823     4821       -2     
  Misses        23407    23407              
- Partials        453      454       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pandaapo pandaapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM

@mxsm mxsm merged commit 715423c into apache:master Nov 17, 2023
@G-XD G-XD deleted the issue_4201 branch November 18, 2023 08:48
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Do some code optimization.[metrics]

3 participants