Skip to content

[ISSUE #4517] Fix Webhook callback path is not a valid Nacos dataId #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 1 commit into from
Oct 28, 2023
Merged

[ISSUE #4517] Fix Webhook callback path is not a valid Nacos dataId #4518

mxsm merged 1 commit into from
Oct 28, 2023

Conversation

@Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Oct 27, 2023

Fixes #4517.

Motivation

image

Modifications

Replace @ # $ % ^ & * , / \ to . instead of encoding them.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #4518 (1dc06ac) into master (62935c4) will increase coverage by 0.42%.
Report is 8 commits behind head on master.
The diff coverage is 28.20%.

❗ Current head 1dc06ac differs from pull request most recent head 6412dc7. Consider uploading reports for the commit 6412dc7 to get more accurate results

@@             Coverage Diff              @@
##             master    #4518      +/-   ##
============================================
+ Coverage     15.47%   15.90%   +0.42%     
- Complexity     1452     1541      +89     
============================================
  Files           691      728      +37     
  Lines         28106    28884     +778     
  Branches       2626     2744     +118     
============================================
+ Hits           4349     4593     +244     
- Misses        23312    23811     +499     
- Partials        445      480      +35
Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 75.00% <ø> (ø)
...he/eventmesh/filter/condition/PrefixCondition.java 100.00% <100.00%> (ø)
...eventmesh/filter/condition/SpecifiedCondition.java 100.00% <100.00%> (ø)
...he/eventmesh/filter/condition/SuffixCondition.java 100.00% <100.00%> (ø)
...eventmesh/metrics/api/model/TcpSummaryMetrics.java 0.00% <ø> (ø)
...he/eventmesh/runtime/boot/EventMeshGrpcServer.java 0.75% <ø> (+<0.01%) ⬆️
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.69% <ø> (+<0.01%) ⬆️
.../runtime/core/protocol/grpc/retry/GrpcRetryer.java 0.00% <ø> (ø)
.../runtime/core/protocol/http/retry/HttpRetryer.java 0.00% <ø> (ø)
...sh/storage/rocketmq/consumer/PushConsumerImpl.java 24.47% <ø> (ø)
... and 51 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 11def17 into apache:master Oct 28, 2023
@pandaapo pandaapo mentioned this pull request Oct 30, 2023
Closed
3 tasks
@Pil0tXia Pil0tXia deleted the pil0txia_bug_4517 branch January 4, 2024 05:13
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@Pil0tXia
[ISSUE apache#4517]Fix Webhook callback path is not a valid Nacos dat…
d9a1d91 
…aId (apache#4518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

@harshithasudhakar harshithasudhakar harshithasudhakar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Webhook callback path is not a valid Nacos dataId

4 participants

@Pil0tXia @mxsm @pandaapo @harshithasudhakar