Skip to content

Conversation

@xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Oct 26, 2023

Fixes #4513 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #4514 (e79d452) into master (a717d35) will decrease coverage by 0.06%.
Report is 2 commits behind head on master.
The diff coverage is 48.00%.

❗ Current head e79d452 differs from pull request most recent head cfe07fb. Consider uploading reports for the commit cfe07fb to get more accurate results

@@             Coverage Diff              @@
##             master    #4514      +/-   ##
============================================
- Coverage     15.95%   15.90%   -0.06%     
- Complexity     1535     1541       +6     
============================================
  Files           713      728      +15     
  Lines         28711    28885     +174     
  Branches       2734     2744      +10     
============================================
+ Hits           4580     4593      +13     
- Misses        23650    23812     +162     
+ Partials        481      480       -1     
Files Coverage Δ
...java/org/apache/eventmesh/filter/PatternEntry.java 85.71% <ø> (ø)
...entmesh/filter/condition/AnythingButCondition.java 20.00% <100.00%> (ø)
.../eventmesh/filter/condition/ConditionsBuilder.java 80.95% <100.00%> (ø)
...he/eventmesh/filter/condition/ExistsCondition.java 75.00% <ø> (ø)
...e/eventmesh/filter/condition/NumericCondition.java 44.44% <ø> (ø)
...he/eventmesh/filter/condition/PrefixCondition.java 100.00% <100.00%> (ø)
...eventmesh/filter/condition/SpecifiedCondition.java 100.00% <ø> (ø)
...he/eventmesh/filter/condition/SuffixCondition.java 100.00% <ø> (ø)
...a/org/apache/eventmesh/filter/pattern/Pattern.java 65.38% <ø> (ø)
.../eventmesh/filter/patternbuild/PatternBuilder.java 72.28% <ø> (ø)
... and 9 more

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit f948cc5 into apache:master Oct 27, 2023
@xwm1992 xwm1992 added this to the 1.10 milestone Dec 12, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…e#4514)

* [ISSUE apache#4513]Add eventmesh filter & transform sub module

* fix check error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]Add eventmesh filter & transform sub module

4 participants