Skip to content

[ISSUE#4508] Add unit test for SpringSourceConnector. #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxsm merged 2 commits into from
Oct 25, 2023
Merged

[ISSUE#4508] Add unit test for SpringSourceConnector. #4509

mxsm merged 2 commits into from
Oct 25, 2023

Conversation

@yanrongzhen
Copy link
Contributor

@yanrongzhen yanrongzhen commented Oct 25, 2023 •
edited
Loading

Fixes #4508 .

Modifications

  • Add unit test for SpringSourceConnector.
  • Resolve dependency confilct.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4509 (b3d4fc5) into master (f046a2e) will increase coverage by 0.56%.
Report is 2 commits behind head on master.
The diff coverage is 66.07%.

❗ Current head b3d4fc5 differs from pull request most recent head 5242af3. Consider uploading reports for the commit 5242af3 to get more accurate results

@@             Coverage Diff              @@
##             master    #4509      +/-   ##
============================================
+ Coverage     15.34%   15.90%   +0.56%     
- Complexity     1454     1541      +87     
============================================
  Files           694      727      +33     
  Lines         28372    28861     +489     
  Branches       2685     2728      +43     
============================================
+ Hits           4354     4591     +237     
- Misses        23572    23788     +216     
- Partials        446      482      +36
Files Coverage Δ
...mesh/common/filter/condition/PrefixxCondition.java 100.00% <100.00%> (ø)
...sh/common/filter/condition/SpecifiedCondition.java 100.00% <100.00%> (ø)
...tmesh/common/filter/condition/SuffixCondition.java 100.00% <100.00%> (ø)
...ventmesh/common/transform/ConstantTransformer.java 100.00% <100.00%> (ø)
...ventmesh/common/transform/OriginalTransformer.java 100.00% <100.00%> (ø)
...ventmesh/common/transform/TemplateTransformer.java 100.00% <100.00%> (ø)
...he/eventmesh/common/transform/TransformerType.java 100.00% <100.00%> (ø)
...tmesh/common/filter/condition/ExistsCondition.java 75.00% <75.00%> (ø)
...rg/apache/eventmesh/common/transform/Variable.java 75.00% <75.00%> (ø)
...g/apache/eventmesh/common/filter/PatternEntry.java 85.71% <85.71%> (ø)
... and 9 more

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm merged commit cf16cf6 into apache:master Oct 25, 2023
Pil0tXia
Pil0tXia reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 added this to the 1.10 milestone Dec 12, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@yanrongzhen
[ISSUE#4508] Add unit test for SpringSourceConnector. (apache#4509)
4cd2041 
* Add unit test for SpringSourceConnector.

* fix build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pil0tXia Pil0tXia Pil0tXia left review comments

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add unit test for SpringSourceConnector.

5 participants

@yanrongzhen @mxsm @pandaapo @Pil0tXia @xwm1992