[ISSUE #4502] Optimizing Log Printing Using the LogUtils (#4502) #4507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
Pil0tXia
requested changes
Oct 24, 2023
Member
Pil0tXia
left a comment
Pil0tXia
left a comment
There was a problem hiding this comment.
Overall great job for a freshman. However, there were some ill-formed modifications introduced. Please revert these non-standard formattings.
eventmesh-common/src/main/java/org/apache/eventmesh/common/file/WatchFileTask.java
Show resolved
Hide resolved
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/codec/Codec.java
Outdated
Show resolved
Hide resolved
...nector-jdbc/src/main/java/org/apache/eventmesh/connector/jdbc/connection/JdbcConnection.java
Outdated
Show resolved
Hide resolved
...nector-jdbc/src/main/java/org/apache/eventmesh/connector/jdbc/connection/JdbcConnection.java
Show resolved
Hide resolved
...nector-jdbc/src/main/java/org/apache/eventmesh/connector/jdbc/connection/JdbcConnection.java
Show resolved
Hide resolved
...c/main/java/org/apache/eventmesh/connector/jdbc/source/dialect/cdc/mysql/MysqlCdcEngine.java
Show resolved
Hide resolved
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/EventMeshUtil.java
Show resolved
Hide resolved
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/EventMeshUtil.java
Show resolved
Hide resolved
mxsm
reviewed
Oct 25, 2023
Member
mxsm
left a comment
mxsm
left a comment
There was a problem hiding this comment.
@scwlkq Thanks for your contribution! I have a small suggestion that PRs should try to do one thing at a time. So this PR should only handle log processing. I saw that there are many format changes and method moves, as well as code deletions, etc. If necessary, these issues can be handled by raising new ISSues instead of handling them in one PR. Try to avoid doing multiple things in one PR.
Codecov Report
@@ Coverage Diff @@
## master #4507 +/- ##
============================================
+ Coverage 15.91% 16.09% +0.18%
- Complexity 1545 1550 +5
============================================
Files 730 730
Lines 28896 28640 -256
Branches 2745 2523 -222
============================================
+ Hits 4600 4611 +11
+ Misses 23816 23581 -235
+ Partials 480 448 -32
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
It was my negligence to configure checkcode but not apply it. I will correct the points mentioned above. Thank you for your patience and correction. |
Pil0tXia
requested changes
Oct 25, 2023
eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/app/service/SubService.java
Show resolved
Hide resolved
Pil0tXia
requested changes
Oct 26, 2023
...rg/apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java
Show resolved
Hide resolved
...ain/java/org/apache/eventmesh/runtime/core/protocol/http/processor/UnSubscribeProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/eventmesh/runtime/core/protocol/http/push/AsyncHTTPPushRequest.java
Show resolved
Hide resolved
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
Show resolved
Hide resolved
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
Outdated
Show resolved
Hide resolved
...-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/EventMeshGrpcConsumer.java
Show resolved
Hide resolved
...tmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/SubStreamHandler.java
Show resolved
Hide resolved
mxsm
reviewed
Oct 27, 2023
Pil0tXia
requested changes
Oct 28, 2023
...bhook-admin/src/main/java/org/apache/eventmesh/webhook/admin/FileWebHookConfigOperation.java
Show resolved
Hide resolved
Pil0tXia
reviewed
Oct 28, 2023
...c/main/java/org/apache/eventmesh/runtime/admin/handler/RedirectClientBySubSystemHandler.java
Show resolved
Hide resolved
mxsm
reviewed
Oct 30, 2023
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/common/RequestContext.java
Outdated
Show resolved
Hide resolved
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java
Outdated
Show resolved
Hide resolved
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/BroadCastSubClient.java
Outdated
Show resolved
Hide resolved
...-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/producer/EventMeshGrpcProducer.java
Outdated
Show resolved
Hide resolved
mxsm
reviewed
Oct 30, 2023
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/BroadCastSubClient.java
Outdated
Show resolved
Hide resolved
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java
Outdated
Show resolved
Hide resolved
mxsm
previously approved these changes
Oct 31, 2023
mxsm
approved these changes
Oct 31, 2023
xwm1992
approved these changes
Oct 31, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4502
Motivation
Modifications
Documentation