[ISSUE#4459] Fix unchecked call to a original type member #4506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaapo
reviewed
Oct 23, 2023
...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4506 +/- ##
============================================
- Coverage 15.47% 15.47% -0.01%
- Complexity 1452 1454 +2
============================================
Files 691 692 +1
Lines 28106 28103 -3
Branches 2626 2612 -14
============================================
- Hits 4349 4348 -1
+ Misses 23312 23310 -2
Partials 445 445
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pandaapo
approved these changes
Oct 23, 2023
Pil0tXia
requested changes
Oct 23, 2023
Comment on lines
139
to
+140
|
|
||
| Set<String> groupTopics = (Set<String>) aclProperties.getExtendedField("topics"); | ||
| Object topics = aclProperties.getExtendedField("topics"); |
Member
There was a problem hiding this comment.
This modification can have impacts on code readability and it is recommended to add some comments if there is no better solution.
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
* Fix compile warnings. * fix exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4459 .
Modifications
Fix unchecked call to a original type member