Skip to content

[ISSUE #4402] Refactor the retry module with HashedWheelTimer. #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 8 commits into from
Oct 25, 2023
Merged

[ISSUE #4402] Refactor the retry module with HashedWheelTimer. #4505

xwm1992 merged 8 commits into from
Oct 25, 2023

Conversation

@yanrongzhen
Copy link
Contributor

@yanrongzhen yanrongzhen commented Oct 23, 2023

Fixes #4402 .

Modifications

  • Add HashedWheelTimer, replacing the retry logic based on DelayQueue.
  • Canonical Retryer naming (EventMeshTcpRetryer - > TcpRetryer)

@Alonexc
Copy link
Contributor

Alonexc commented Oct 23, 2023

Please fix the build error.

@yanrongzhen
Copy link
Contributor Author

yanrongzhen commented Oct 23, 2023

Please fix the build error.

CI error has been fixed.

@Pil0tXia
Copy link
Member

Pil0tXia commented Oct 23, 2023

LGTM

@yanrongzhen yanrongzhen requested a review from pandaapo October 24, 2023 02:46
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #4505 (4af1cc1) into master (d3f688d) will decrease coverage by 0.13%.
Report is 1 commits behind head on master.
The diff coverage is 1.29%.

❗ Current head 4af1cc1 differs from pull request most recent head f67126c. Consider uploading reports for the commit f67126c to get more accurate results

@@             Coverage Diff              @@
##             master    #4505      +/-   ##
============================================
- Coverage     15.47%   15.34%   -0.13%     
- Complexity     1452     1454       +2     
============================================
  Files           691      694       +3     
  Lines         28106    28372     +266     
  Branches       2626     2685      +59     
============================================
+ Hits           4349     4354       +5     
- Misses        23312    23572     +260     
- Partials        445      446       +1
Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 75.00% <ø> (ø)
...eventmesh/metrics/api/model/TcpSummaryMetrics.java 0.00% <ø> (ø)
...he/eventmesh/runtime/boot/EventMeshGrpcServer.java 0.75% <ø> (+<0.01%) ⬆️
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.69% <ø> (+<0.01%) ⬆️
.../runtime/core/protocol/grpc/retry/GrpcRetryer.java 0.00% <ø> (ø)
.../runtime/core/protocol/http/retry/HttpRetryer.java 0.00% <ø> (ø)
...sh/storage/rocketmq/consumer/PushConsumerImpl.java 24.47% <ø> (ø)
...ics/prometheus/metrics/PrometheusGrpcExporter.java 0.00% <0.00%> (ø)
...ics/prometheus/metrics/PrometheusHttpExporter.java 0.00% <0.00%> (ø)
...rics/prometheus/metrics/PrometheusTcpExporter.java 0.00% <0.00%> (ø)
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yanrongzhen
Copy link
Contributor Author

yanrongzhen commented Oct 24, 2023

@pandaapo Please review the new changes, thanks.

@yanrongzhen yanrongzhen requested a review from Pil0tXia October 24, 2023 05:41
@xwm1992 xwm1992 merged commit f046a2e into apache:master Oct 25, 2023
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@yanrongzhen
[ISSUE apache#4402] Refactor the retry module with HashedWheelTimer. (a…
6ff4dc6 
…pache#4505)

* Add HashedWheelTimer.

* Integrate HashedWheelTimer to AbstractRetryer.

* Refactor Retryer, RetryContxt.

* Remove DelayQueue dependency.

* Add retry debug log.

* Fix checkstyle.

* Optimize Retry interface.

* Remove init method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@pandaapo pandaapo pandaapo approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Enhancement] Refactoring retry module

5 participants

@yanrongzhen @Alonexc @Pil0tXia @xwm1992 @pandaapo