Skip to content

[ISSUE #4415] Add Promethus source connector #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 8 commits into from
Oct 22, 2023
Merged

[ISSUE #4415] Add Promethus source connector #4493

xwm1992 merged 8 commits into from
Oct 22, 2023

Conversation

@willimpo
Copy link
Contributor

@willimpo willimpo commented Oct 18, 2023

Fixes #4415.

Motivation

Add Promethus source connector.

Modifications

Add new source connector module for prometheus

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #4493 (4a53635) into master (f629730) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 4a53635 differs from pull request most recent head a55f7a4. Consider uploading reports for the commit a55f7a4 to get more accurate results

@@             Coverage Diff              @@
##             master    #4493      +/-   ##
============================================
+ Coverage     15.46%   15.47%   +0.01%     
  Complexity     1452     1452              
============================================
  Files           691      691              
  Lines         28101    28106       +5     
  Branches       2624     2626       +2     
============================================
+ Hits           4345     4349       +4     
- Misses        23309    23312       +3     
+ Partials        447      445       -2
Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 75.00% <ø> (ø)
...entmesh/common/utils/ConfigurationContextUtil.java 70.00% <ø> (ø)
...ics/prometheus/metrics/PrometheusGrpcExporter.java 0.00% <ø> (ø)
...ics/prometheus/metrics/PrometheusHttpExporter.java 0.00% <ø> (ø)
...rics/prometheus/metrics/PrometheusTcpExporter.java 0.00% <ø> (ø)
.../prometheus/utils/PrometheusExporterConstants.java 0.00% <ø> (ø)
...apache/eventmesh/runtime/boot/EventMeshServer.java 0.00% <ø> (ø)
...apache/eventmesh/client/http/ProtocolConstant.java 0.00% <ø> (ø)
...e/eventmesh/client/tcp/common/EventMeshCommon.java 0.00% <ø> (ø)
...e/eventmesh/common/config/CommonConfiguration.java 83.33% <0.00%> (ø)
... and 9 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pandaapo
pandaapo previously approved these changes Oct 20, 2023
View reviewed changes
@willimpo
Copy link
Contributor Author

willimpo commented Oct 20, 2023 •
edited
Loading

@pandaapo hi may I ask why the package guava-retrying-2.0.0.jar is failed in License Check? It is normal in local
Thanks

@pandaapo
Copy link
Member

pandaapo commented Oct 20, 2023 •
edited
Loading

@pandaapo hi may I ask why the package guava-retrying-2.0.0.jar is failed in License Check? It is normal in local Thanks

Could you show me the detailed CI error information? I can't see it.
捕获

Additionally, you can try updating the file 'knowledge-dependencies.txt'.

@willimpo
Copy link
Contributor Author

willimpo commented Oct 20, 2023

@pandaapo hi may I ask why the package guava-retrying-2.0.0.jar is failed in License Check? It is normal in local Thanks

Could you show me the detailed CI error information? I can't see it. 捕获

Additionally, you can try updating the file 'knowledge-dependencies.txt'.

it is like this as follow. And where is the file 'knowledge-dependencies.txt'?
image

@pandaapo
Copy link
Member

pandaapo commented Oct 20, 2023

And where is the file 'knowledge-dependencies.txt'?

It's my typo error. It should be 'known-dependencies.txt'.

@willimpo
Copy link
Contributor Author

willimpo commented Oct 20, 2023

And where is the file 'knowledge-dependencies.txt'?

It's my typo error. It should be 'known-dependencies.txt'.

I found it and I'll try again. Thanks

@willimpo
Copy link
Contributor Author

willimpo commented Oct 20, 2023

@xwm1992 please review again, thanks

mxsm
mxsm approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit d3f688d into apache:master Oct 22, 2023
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@willimpo
[ISSUE apache#4415] Add Promethus source connector (apache#4493)
526bd34 
* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@mxsm mxsm mxsm approved these changes

@pandaapo pandaapo pandaapo approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Feature] Add Promethus source connector

5 participants

@willimpo @pandaapo @xwm1992 @mxsm @Pil0tXia