[ISSUE #4275] Support subscription info management with eventmesh-admin module #4468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsm
reviewed
Oct 2, 2023
eventmesh-connectors/eventmesh-connector-rocketmq/src/main/resources/source-config.yml
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
============================================
- Coverage 16.90% 15.57% -1.33%
- Complexity 1458 1475 +17
============================================
Files 621 698 +77
Lines 25825 28203 +2378
Branches 2415 2633 +218
============================================
+ Hits 4365 4394 +29
- Misses 21021 23361 +2340
- Partials 439 448 +9
... and 193 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
requested changes
Oct 3, 2023
eventmesh-admin-new/src/main/java/org/apache/eventmesh/adminnew/EventmeshAdminApplication.java
Outdated
Show resolved
Hide resolved
...sh-admin-new/src/test/java/org/apache/eventmesh/adminnew/EventmeshAdminApplicationTests.java
Outdated
Show resolved
Hide resolved
xwm1992
previously approved these changes
Oct 4, 2023
xwm1992
approved these changes
Oct 5, 2023
3 tasks
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…sh-admin module (apache#4468) * init: Spring Initializr * init: add basic configurations and dependencies * init: merge Gradle Groovy DSL to Kotlin DSL * fix: resolve springdoc compatibility and select kotlin as DSL * config: use nacos, REVERT BEFORE MERGE * dep: nacos-client dependency and test endpoint * config: use rocketmq connector, REVERT BEFORE MERGE * dep: fix springdoc version * config: connector namesrv, REVERT BEFORE MERGE * feat: Realize multi-implements based on config * feat: get one nacos config by dataId * feat: get nacos config list with OpenAPI * chore: fix checkstyle * feat: config content base64 encode * feat: use json to output Session toString * optimize: endpoint support returning error message * optimize: return an object instead of JSON string * Revert config changes * Use Gradle Groovy DSL instead of Kotlin DSL * feat: support for building and running with docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4275.
Motivation
This is a subtask of GLCC Subject #4040.
Design Document: https://docs.qq.com/doc/DSk9NU1JiRlBpSXln
eventmesh-adminmodule is going to be substituted to be deployed independently. For now, a new moduleeventmesh-consoleis added to migrate functions ofeventmesh-admingradually.TheUsing Groovy DSL.eventmesh-admin-kotlinmodule used Gradle Kotlin DSL instead of Gradle Groovy DSL to manage dependencies, because Kotlin DSL is the default Gradle DSL currently and it has many advantages over Groovy DSL. Theeventmesh-admin-newmodule used Gradle DSL for comparison and will be deleted before merged if ok.Modifications
Subscription management functions are now available.
Connection management function will be finished after EventMesh K8s operator is supported.
The
toStringmethod ofSessionnow supports Json output in order to be displayed oneventmesh-dashboard.Before:
After:
Todo
storage-plugin.adminwill be migrated toeventmesh-admin.runtime.adminwill use Netty instead of Sun HttpServer.Documentation