Skip to content

[ISSUE #4456] startup failure caused by Retryer #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 1 commit into from
Sep 25, 2023
Merged

[ISSUE #4456] startup failure caused by Retryer #4460

xwm1992 merged 1 commit into from
Sep 25, 2023

Conversation

@pandaapo
Copy link
Member

@pandaapo pandaapo commented Sep 25, 2023

Fixes #4456.

Motivation

NPE

Modifications

Remove incorrect local variable

Documentation

  • Does this pull request introduce a new feature? no

@pandaapo pandaapo changed the title [issue #4456] startup failure caused by Retryer [ISSUE #4456] startup failure caused by Retryer Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #4460 (5a447ac) into master (f8d4023) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 5a447ac differs from pull request most recent head 74657a7. Consider uploading reports for the commit 74657a7 to get more accurate results

@@            Coverage Diff            @@
##             master    #4460   +/-   ##
=========================================
  Coverage     15.98%   15.98%           
  Complexity     1475     1475           
=========================================
  Files           690      690           
  Lines         27480    27480           
  Branches       2567     2567           
=========================================
  Hits           4392     4392           
  Misses        22640    22640           
  Partials        448      448
Files Changed Coverage Δ
...entmesh/runtime/core/protocol/AbstractRetryer.java 0.00% <ø> (ø)
.../runtime/core/protocol/grpc/retry/GrpcRetryer.java 0.00% <0.00%> (ø)
.../runtime/core/protocol/http/retry/HttpRetryer.java 0.00% <0.00%> (ø)
.../tcp/client/session/retry/EventMeshTcpRetryer.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pil0tXia
Pil0tXia approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit b4feffc into apache:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@mxsm mxsm mxsm approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] startup failure caused by Retryer

4 participants

@pandaapo @xwm1992 @mxsm @Pil0tXia