Skip to content

[ISSUE #4396] Realize the admin function for Kafka storage-plugin #4438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qqeasonchen merged 10 commits into from
Sep 12, 2023
Merged

[ISSUE #4396] Realize the admin function for Kafka storage-plugin #4438

qqeasonchen merged 10 commits into from
Sep 12, 2023

Conversation

@Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Sep 7, 2023

Fixes #4396.

Motivation

image

Modifications

  • Supports configuring the number of partitions and ISR replicas to which the topic belongs.
  • Has detailed error messages.
  • Although storage.admin will be migrated to the admin module in the near future, this PR is already halfway done, so I finished it up.

image

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@xwm1992 xwm1992 changed the title [ISSUE #4396] Realize the admin function for Kafka stroage-plugin [ISSUE #4396] Realize the admin function for Kafka storage-plugin Sep 8, 2023
@Pil0tXia Pil0tXia requested a review from pandaapo September 8, 2023 02:06
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #4438 (5d5bdda) into master (50d6113) will decrease coverage by 0.95%.
Report is 42 commits behind head on master.
The diff coverage is 8.85%.

❗ Current head 5d5bdda differs from pull request most recent head d978b9e. Consider uploading reports for the commit d978b9e to get more accurate results

@@             Coverage Diff              @@
##             master    #4438      +/-   ##
============================================
- Coverage     17.85%   16.90%   -0.95%     
+ Complexity     1514     1458      -56     
============================================
  Files           602      621      +19     
  Lines         25518    25825     +307     
  Branches       2400     2415      +15     
============================================
- Hits           4555     4365     -190     
- Misses        20524    21021     +497     
  Partials        439      439
Files Changed Coverage Δ
...otocol/catalog/protos/QueryOperationsResponse.java 0.00% <0.00%> (ø)
...mmon/protocol/catalog/protos/RegistryResponse.java 0.00% <0.00%> (ø)
...pache/eventmesh/connector/jdbc/CatalogChanges.java 0.00% <0.00%> (ø)
...ava/org/apache/eventmesh/connector/jdbc/Field.java 0.00% <0.00%> (ø)
...ache/eventmesh/connector/jdbc/JdbcConnectData.java 0.00% <0.00%> (ø)
...e/eventmesh/connector/jdbc/JdbcDriverMetaData.java 0.00% <0.00%> (ø)
...a/org/apache/eventmesh/connector/jdbc/Payload.java 0.00% <0.00%> (ø)
...va/org/apache/eventmesh/connector/jdbc/Schema.java 0.00% <0.00%> (ø)
...he/eventmesh/connector/jdbc/config/JdbcConfig.java 0.00% <0.00%> (ø)
...ntmesh/connector/jdbc/config/JdbcServerConfig.java 0.00% <0.00%> (ø)
... and 124 more

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Sep 8, 2023

Made a minor performance optimization by supporting topic batch listing.

@qqeasonchen qqeasonchen merged commit 6dfd46d into apache:master Sep 12, 2023
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
@Pil0tXia Pil0tXia deleted the pil0txia_feat_4396 branch January 4, 2024 05:06
@Pil0tXia Pil0tXia mentioned this pull request Apr 9, 2024
Closed
3 tasks
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@Pil0tXia
[ISSUE apache#4396] Realize the admin function for Kafka storage-plug…
370fa26 
…in (apache#4438)

* config: kafka-storage-plugin, RESTORE BEFORE MERGE

* fix: meshMqAdmin not loaded at startup

* feat: implement getTopic

* feat: get all history message count

* feat: implement createTopic

* optimize: remove redundant bootstrap.server config and add new configs

* feat: implement deleteTopic and handle exceptions

* Revert "config: kafka-storage-plugin, RESTORE BEFORE MERGE"

This reverts commit b7b607e.

* chore: move kafka comment to a more suitable place.

* optimize: support topic batch listing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabian4 fabian4 fabian4 left review comments

@xwm1992 xwm1992 xwm1992 approved these changes

@qqeasonchen qqeasonchen qqeasonchen approved these changes

@pandaapo pandaapo Awaiting requested review from pandaapo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Feature] Realize the admin function for Kafka stroage-plugin

5 participants

@Pil0tXia @xwm1992 @qqeasonchen @pandaapo @fabian4