Skip to content

[ISSUE #4409]Support source connector jdbc handle snapshot data for mysql #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 1 commit into from
Sep 13, 2023
Merged

[ISSUE #4409]Support source connector jdbc handle snapshot data for mysql #4434

xwm1992 merged 1 commit into from
Sep 13, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Sep 6, 2023

Fixes #4409

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

  • After downloading the source code, you need to compile the project to generate the relevant Java classes for ANTLR4.
  • Add support for snapshot data in MySQL and integrated ANTLR4 for parsing MySQL SQL statements.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mxsm mxsm force-pushed the evetmesh-jdbc-mysql-snapshot branch from 97819d6 to 6b4506e Compare September 6, 2023 14:07
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #4434 (6cfd67f) into master (da02765) will decrease coverage by 0.97%.
The diff coverage is 0.61%.

❗ Current head 6cfd67f differs from pull request most recent head 6b4506e. Consider uploading reports for the commit 6b4506e to get more accurate results

@@             Coverage Diff              @@
##             master    #4434      +/-   ##
============================================
- Coverage     17.47%   16.50%   -0.97%     
- Complexity     1545     1562      +17     
============================================
  Files           665      733      +68     
  Lines         26477    28183    +1706     
  Branches       2432     2587     +155     
============================================
+ Hits           4626     4653      +27     
- Misses        21397    23067    +1670     
- Partials        454      463       +9
Files Changed Coverage Δ
...he/eventmesh/connector/jdbc/AbstractPartition.java 0.00% <0.00%> (ø)
...pache/eventmesh/connector/jdbc/CatalogChanges.java 0.00% <ø> (ø)
...ava/org/apache/eventmesh/connector/jdbc/Field.java 0.00% <0.00%> (ø)
...esh/connector/jdbc/PartitionOffSetContextPair.java 0.00% <0.00%> (ø)
...a/org/apache/eventmesh/connector/jdbc/Payload.java 0.00% <0.00%> (ø)
...va/org/apache/eventmesh/connector/jdbc/Schema.java 0.00% <0.00%> (ø)
...eventmesh/connector/jdbc/UniversalJdbcContext.java 0.00% <0.00%> (ø)
...entmesh/connector/jdbc/UniversalOffsetContext.java 0.00% <0.00%> (ø)
...entmesh/connector/jdbc/antlr4/Antlr4DdlParser.java 0.00% <0.00%> (ø)
...tor/jdbc/connection/mysql/MysqlJdbcConnection.java 0.00% <0.00%> (ø)
... and 74 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm requested review from qqeasonchen and xwm1992 September 6, 2023 14:59
@mxsm
Copy link
Member Author

mxsm commented Sep 8, 2023

ping @qqeasonchen @xwm1992

@xwm1992 xwm1992 merged commit 74f9abf into apache:master Sep 13, 2023
@mxsm mxsm deleted the evetmesh-jdbc-mysql-snapshot branch September 13, 2023 04:16
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@mxsm
[ISSUE apache#4409]Support source connector jdbc handle snapshot data…
f96c6cf 
… for mysql (apache#4434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@qqeasonchen qqeasonchen qqeasonchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Feature] Support source connector jdbc handle snapshot data for mysql

4 participants

@mxsm @xwm1992 @qqeasonchen @pandaapo