Skip to content

Conversation

@fabian4
Copy link
Member

@fabian4 fabian4 commented Sep 5, 2023

Fixes #4277.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Add eventmesh-connector-knative

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@fabian4
Copy link
Member Author

fabian4 commented Sep 5, 2023

The knative source connector need to expose a public endpoint to Knative broker
https://knative.dev/docs/eventing/sinks/

I'll do it in another pr.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4428 (362a35d) into master (3f2fd1c) will not change coverage.
The diff coverage is n/a.

❗ Current head 362a35d differs from pull request most recent head 0b24d3d. Consider uploading reports for the commit 0b24d3d to get more accurate results

@@            Coverage Diff            @@
##             master    #4428   +/-   ##
=========================================
  Coverage     17.47%   17.47%           
  Complexity     1545     1545           
=========================================
  Files           665      665           
  Lines         26477    26477           
  Branches       2432     2432           
=========================================
  Hits           4626     4626           
  Misses        21397    21397           
  Partials        454      454           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit da02765 into apache:master Sep 6, 2023
@fabian4 fabian4 deleted the knative_plugin branch September 6, 2023 05:14
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
* feat: add eventmesh-connector-knative.

* feat: add eventmesh-connector-knative.

* feat: add eventmesh-connector-knative.

* feat: add eventmesh-connector-knative.

* feat: add eventmesh-connector-knative.

* feat: add eventmesh-connector-knative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Move Knative plugin into Connector from Storage plugin moudle

4 participants