Skip to content

Conversation

@iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Aug 13, 2023

Fixes #4354

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please create a corresponding issue and standardize your PR title and Fixes.

@iwangjie iwangjie changed the title fix: fix spelling. [ISSUE #4354] fix: fix spelling. Aug 13, 2023
@iwangjie
Copy link
Contributor Author

LGTM. Please create a corresponding issue and standardize your PR title and Fixes.

thank you, done!

@harshithasudhakar
Copy link
Member

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #4353 (a874181) into master (a350ffc) will not change coverage.
The diff coverage is n/a.

❗ Current head a874181 differs from pull request most recent head e8c10ef. Consider uploading reports for the commit e8c10ef to get more accurate results

@@            Coverage Diff            @@
##             master    #4353   +/-   ##
=========================================
  Coverage     17.74%   17.74%           
  Complexity     1500     1500           
=========================================
  Files           594      594           
  Lines         25351    25351           
  Branches       2395     2395           
=========================================
  Hits           4498     4498           
  Misses        20419    20419           
  Partials        434      434           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm changed the title [ISSUE #4354] fix: fix spelling. [ISSUE #4354] Fix spelling mistake Aug 13, 2023
@mxsm mxsm merged commit dbfb571 into apache:master Aug 13, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] fix spelling mistakes.

5 participants