Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Aug 12, 2023

Fixes #4345

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

-Fix publish EventMeshMessage without requestCode throw java.lang.NullPointerException

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #4352 (47993d0) into master (a350ffc) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 88.46%.

❗ Current head 47993d0 differs from pull request most recent head b759be1. Consider uploading reports for the commit b759be1 to get more accurate results

@@             Coverage Diff              @@
##             master    #4352      +/-   ##
============================================
+ Coverage     17.74%   17.81%   +0.07%     
- Complexity     1500     1503       +3     
============================================
  Files           594      594              
  Lines         25351    25352       +1     
  Branches       2395     2395              
============================================
+ Hits           4498     4517      +19     
+ Misses        20419    20401      -18     
  Partials        434      434              
Files Changed Coverage Δ
...he/eventmesh/common/protocol/http/HttpCommand.java 69.07% <25.00%> (+16.49%) ⬆️
.../common/protocol/http/common/EventMeshRetCode.java 100.00% <100.00%> (ø)
...tmesh/common/protocol/http/common/RequestCode.java 61.76% <100.00%> (+1.15%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm requested a review from pandaapo August 13, 2023 15:06
@xwm1992 xwm1992 merged commit 8be4180 into apache:master Aug 14, 2023
@mxsm mxsm deleted the eventmesh-4345 branch August 14, 2023 02:10
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…hrow java.lang.NullPointerException (apache#4352)

* [ISSUE apache#4345]Fix publish EventMeshMessage without requestCode throw java.lang.NullPointerException

* optimize logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Publish EventMeshMessage without requestCode throw java.lang.NullPointerException

4 participants