-
Notifications
You must be signed in to change notification settings - Fork 641
[ISSUE #4328] Add offsetManagement Service for connectors #4329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mxsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xwm1992 CI not pass! need to fix it
Codecov Report
@@ Coverage Diff @@
## master #4329 +/- ##
============================================
+ Coverage 16.35% 16.36% +0.01%
- Complexity 1362 1363 +1
============================================
Files 594 594
Lines 25393 25394 +1
Branches 2393 2393
============================================
+ Hits 4152 4155 +3
+ Misses 20818 20817 -1
+ Partials 423 422 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lrhkobe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[ISSUE apache#4328] Add offsetManagement Service for connectors
Fixes #4328 .
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation