Skip to content

Conversation

@xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Aug 4, 2023

Fixes #4328 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

qqeasonchen
qqeasonchen previously approved these changes Aug 4, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xwm1992 CI not pass! need to fix it

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4329 (e004171) into master (800b628) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e004171 differs from pull request most recent head 9621900. Consider uploading reports for the commit 9621900 to get more accurate results

@@             Coverage Diff              @@
##             master    #4329      +/-   ##
============================================
+ Coverage     16.35%   16.36%   +0.01%     
- Complexity     1362     1363       +1     
============================================
  Files           594      594              
  Lines         25393    25394       +1     
  Branches       2393     2393              
============================================
+ Hits           4152     4155       +3     
+ Misses        20818    20817       -1     
+ Partials        423      422       -1     
Files Changed Coverage Δ
...g/apache/eventmesh/spi/EventMeshExtensionType.java 92.85% <100.00%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lrhkobe lrhkobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wqliang wqliang merged commit 50bbaec into apache:master Aug 8, 2023
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
[ISSUE apache#4328] Add offsetManagement Service for connectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add offsetManagement Service for connectors

7 participants