-
Notifications
You must be signed in to change notification settings - Fork 641
[Feature #4032] Fix redis codec #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4301 +/- ##
============================================
- Coverage 16.87% 16.35% -0.52%
+ Complexity 1428 1359 -69
============================================
Files 593 594 +1
Lines 26035 25419 -616
Branches 2366 2394 +28
============================================
- Hits 4394 4158 -236
+ Misses 21215 20838 -377
+ Partials 426 423 -3
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...tor-redis/src/main/java/org/apache/eventmesh/connector/redis/cloudevent/CloudEventCodec.java
Show resolved
Hide resolved
...orage-redis/src/main/java/org/apache/eventmesh/storage/redis/cloudevent/CloudEventCodec.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I tried testing your
eventmesh-connector-redismodule includingCloudEventCodeclocally, but unfortunately, I didn't see any results. The only configuration change I made was to modify thetopicinsource-config.ymltoTopicTest2. Could you please provide me with the correct verification steps so that I can re-validate? Thank you. -
I'm a bit confused. In your code, you write the type for Redis as
ConnectRecord, butCloudEventCodecis used for encoding and decoding theCloudEventtype. Could you clarify my confusion? -
If
CloudEventCodechas no problem, I suggest that you write the commentDuplicate with org.apache.eventmesh.....CloudEventCodecin the code of your module instead ofeventmesh-storage-redismodule, considering that you copied the code from that module to yours.
It is all fixed now. (only CloudEvent message support yet)
To Verify SinkWorker
To Verify SourceWorker
|
* fix: add cloudEventCodec for redis connector. * fix: add cloudEventCodec for redis connector. * fix import order. * fix: add doc. * fix: adjust cloudevent encode and decode.
Fixes #4032.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Add support for cloudevent data encoding and decoding with the way in redis-storage.
Documentation