[ISSUE #4286] Fix response body is not recognised as JSON in query WebHook config endpoints #4287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4287 +/- ##
=========================================
Coverage 16.87% 16.87%
- Complexity 1426 1427 +1
=========================================
Files 593 593
Lines 26068 26068
Branches 2396 2396
=========================================
+ Hits 4398 4400 +2
+ Misses 21229 21228 -1
+ Partials 441 440 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pandaapo
approved these changes
Jul 26, 2023
xwm1992
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4286.
Motivation
The response body is not recognised as JSON in Postman, and the Content-Type header missing:
Modifications
That's because
NetUtils.sendSuccessResponseHeaders(httpExchange);is in front ofhttpExchange.getResponseHeaders().add(CONTENT_TYPE, APPLICATION_JSON);and headers are sent out before they are set correctly.Documentation