Skip to content

Conversation

@fabian4
Copy link
Member

@fabian4 fabian4 commented Jul 25, 2023

Fixes #4032.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

fabian4 and others added 10 commits July 24, 2023 17:52
…rotocolAdaptor] (apache#4270)

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]
…ile (apache#4257)

* [ISSUE apache#4099]: Refactor re-used constant's usage from dedicated file

* [ISSUE apache#4099] Rename some constants for mongodb storage plugin

* [ISSUE apache#4099] Refactor constant imports in mongodb cloud event util

* [ISSUE apache#4099]: Replace contants imports to class import in mongo cloud event util
…dis_connector

# Conflicts:
#	eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/sink/config/RedisSinkConfig.java
#	eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/sink/config/SinkConnectorConfig.java
#	eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/sink/connector/RedisSinkConnector.java
#	eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/source/config/RedisSourceConfig.java
#	eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/source/config/SourceConnectorConfig.java
#	eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/source/connector/RedisSourceConnector.java
#	eventmesh-connectors/eventmesh-connector-redis/src/main/resources/sink-config.yml
#	eventmesh-connectors/eventmesh-connector-redis/src/main/resources/source-config.yml
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabian4 Please check code style and CI not pass

@fabian4 fabian4 requested a review from mxsm July 25, 2023 14:32
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@fabian4 fabian4 requested a review from Pil0tXia July 25, 2023 15:39
@fabian4
Copy link
Member Author

fabian4 commented Jul 25, 2023

The data encoding and decoding still in progress.

@Alonexc
Copy link
Contributor

Alonexc commented Jul 26, 2023

image
please check checkstyle.

@fabian4
Copy link
Member Author

fabian4 commented Jul 26, 2023

image please check checkstyle.

Just fixed it.

BTW is there any way to check it automatically in my local IDEA. How to make it import the dependency with the order we need as the rules said.

@Pil0tXia
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4280 (2b6e38c) into master (c18ef05) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 2b6e38c differs from pull request most recent head 5a9c815. Consider uploading reports for the commit 5a9c815 to get more accurate results

@@             Coverage Diff              @@
##             master    #4280      +/-   ##
============================================
- Coverage     16.87%   16.86%   -0.01%     
- Complexity     1426     1427       +1     
============================================
  Files           593      593              
  Lines         26068    26064       -4     
  Branches       2396     2394       -2     
============================================
- Hits           4398     4396       -2     
+ Misses        21229    21226       -3     
- Partials        441      442       +1     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 6df8428 into apache:master Jul 27, 2023
@fabian4 fabian4 deleted the add_redis_connector branch July 27, 2023 07:16
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
@xwm1992 xwm1992 changed the title [Feature #4032] Add Redis Connector modules [ISSUE #4032] Add Redis Connector modules Dec 12, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
* feat: add redis connector.

* feat: add redis connector.

* feat: add redis connector.

* feat: add redis connector.

* feat: add redis connector.

* [ISSUE apache#4023]Comparison using reference equality instead of value equality.[Operation] (apache#4276)

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] (apache#4270)

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]

* [ISSUE apache#4099]Refactor re-used constant's usage from dedicated file (apache#4257)

* [ISSUE apache#4099]: Refactor re-used constant's usage from dedicated file

* [ISSUE apache#4099] Rename some constants for mongodb storage plugin

* [ISSUE apache#4099] Refactor constant imports in mongodb cloud event util

* [ISSUE apache#4099]: Replace contants imports to class import in mongo cloud event util

* fix import order.

* fix import order.

* fix import order.

* fix import order.

---------

Co-authored-by: Fabian Bao <[email protected]>
Co-authored-by: kyooosukedn <[email protected]>
Co-authored-by: Sam V Jose <[email protected]>
Co-authored-by: ruhshan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add Redis Connector modules

9 participants