-
Notifications
You must be signed in to change notification settings - Fork 641
[ISSUE #4032] Add Redis Connector modules #4280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ue equality.[Operation] (apache#4276)
…rotocolAdaptor] (apache#4270) * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor]
…ile (apache#4257) * [ISSUE apache#4099]: Refactor re-used constant's usage from dedicated file * [ISSUE apache#4099] Rename some constants for mongodb storage plugin * [ISSUE apache#4099] Refactor constant imports in mongodb cloud event util * [ISSUE apache#4099]: Replace contants imports to class import in mongo cloud event util
…dis_connector # Conflicts: # eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/sink/config/RedisSinkConfig.java # eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/sink/config/SinkConnectorConfig.java # eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/sink/connector/RedisSinkConnector.java # eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/source/config/RedisSourceConfig.java # eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/source/config/SourceConnectorConfig.java # eventmesh-connectors/eventmesh-connector-redis/src/main/java/org/apache/eventmesh/connector/redis/source/connector/RedisSourceConnector.java # eventmesh-connectors/eventmesh-connector-redis/src/main/resources/sink-config.yml # eventmesh-connectors/eventmesh-connector-redis/src/main/resources/source-config.yml
mxsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabian4 Please check code style and CI not pass
Pil0tXia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
...ctor-redis/src/main/java/org/apache/eventmesh/connector/redis/server/RedisConnectServer.java
Outdated
Show resolved
Hide resolved
eventmesh-connectors/eventmesh-connector-redis/src/main/resources/sink-config.yml
Outdated
Show resolved
Hide resolved
|
The data encoding and decoding still in progress. |
Codecov Report
@@ Coverage Diff @@
## master #4280 +/- ##
============================================
- Coverage 16.87% 16.86% -0.01%
- Complexity 1426 1427 +1
============================================
Files 593 593
Lines 26068 26064 -4
Branches 2396 2394 -2
============================================
- Hits 4398 4396 -2
+ Misses 21229 21226 -3
- Partials 441 442 +1 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mxsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: add redis connector. * feat: add redis connector. * feat: add redis connector. * feat: add redis connector. * feat: add redis connector. * [ISSUE apache#4023]Comparison using reference equality instead of value equality.[Operation] (apache#4276) * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] (apache#4270) * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4269] Used switch to replace the if-else. [MeshMessageProtocolAdaptor] * [ISSUE apache#4099]Refactor re-used constant's usage from dedicated file (apache#4257) * [ISSUE apache#4099]: Refactor re-used constant's usage from dedicated file * [ISSUE apache#4099] Rename some constants for mongodb storage plugin * [ISSUE apache#4099] Refactor constant imports in mongodb cloud event util * [ISSUE apache#4099]: Replace contants imports to class import in mongo cloud event util * fix import order. * fix import order. * fix import order. * fix import order. --------- Co-authored-by: Fabian Bao <[email protected]> Co-authored-by: kyooosukedn <[email protected]> Co-authored-by: Sam V Jose <[email protected]> Co-authored-by: ruhshan <[email protected]>


Fixes #4032.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation