Skip to content

[ISSUE #4222]support metadata management in http protocol #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 3 commits into from
Jul 17, 2023
Merged

[ISSUE #4222]support metadata management in http protocol #4231

xwm1992 merged 3 commits into from
Jul 17, 2023

Conversation

@lrhkobe
Copy link
Contributor

@lrhkobe lrhkobe commented Jul 15, 2023 •
edited by xwm1992
Loading

Fixes #4222.

Motivation

  • supprot metadata management in http protocol

Modifications

  • add CreateTopicProcessor.java for event creation
  • add DeleteTopicProcessor.java for event deletion
  • add QuerySubscriptionProcessor.java for subscription query

@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #4231 (0636905) into master (c5357d6) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head 0636905 differs from pull request most recent head 3a9e2fc. Consider uploading reports for the commit 3a9e2fc to get more accurate results

@@             Coverage Diff              @@
##             master    #4231      +/-   ##
============================================
- Coverage     16.90%   16.77%   -0.14%     
+ Complexity     1416     1415       -1     
============================================
  Files           589      592       +3     
  Lines         25837    26039     +202     
  Branches       2394     2403       +9     
============================================
- Hits           4369     4367       -2     
- Misses        21031    21234     +203     
- Partials        437      438       +1
Impacted Files Coverage Δ
.../common/protocol/http/common/EventMeshRetCode.java 0.00% <0.00%> (ø)
...ntmesh/common/protocol/http/common/RequestURI.java 0.00% <0.00%> (ø)
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.52% <0.00%> (-0.02%) ⬇️
.../protocol/http/processor/CreateTopicProcessor.java 0.00% <0.00%> (ø)
.../protocol/http/processor/DeleteTopicProcessor.java 0.00% <0.00%> (ø)
...col/http/processor/QuerySubscriptionProcessor.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm requested changes Jul 16, 2023
View reviewed changes
...ain/java/org/apache/eventmesh/runtime/core/protocol/http/processor/DeleteTopicProcessor.java
Copy link
Member

@mxsm mxsm Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file format seems to be incorrect. Please fix it.

@xwm1992 xwm1992 merged commit e287e76 into apache:master Jul 17, 2023
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@lrhkobe
[ISSUE apache#4222]support metadata management in http protocol (apac…
fd14193 
…he#4231)

* support metadata management in http protocol

* fix checkstyle:file format problem

* fix checkstyle problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm requested changes

@wqliang wqliang wqliang approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

[Enhancement] Support metadata management in http protocol

5 participants

@lrhkobe @wqliang @xwm1992 @mxsm @pandaapo