Skip to content

[ISSUE #4217 #4218 #4219 #4220]Some bug fixes and optimization in http protocol #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wqliang merged 13 commits into from
Jul 13, 2023
Merged

[ISSUE #4217 #4218 #4219 #4220]Some bug fixes and optimization in http protocol #4221

wqliang merged 13 commits into from
Jul 13, 2023

Conversation

@lrhkobe
Copy link
Contributor

@lrhkobe lrhkobe commented Jul 12, 2023 •
edited by xwm1992
Loading

Fixes #4217，
Fixes #4218，
Fixes #4219，
Fixes #4220

Modifications

  • Add response status code setting for http request
  • support application/protobuf
  • Default parameter optimization and codec optimization
  • Optimize remote subscribe and unsubscribe interface
  • fix NPE, security upgrade
  • log optimization
  • Authentication supports version number verification
  • Set http request timeout
  • Fix concurrent modification exception
  • Fix the port occupation that caused the startup fail, and the process did not exit

@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #4221 (ac9519f) into master (3392b45) will decrease coverage by 0.04%.
The diff coverage is 2.58%.

❗ Current head ac9519f differs from pull request most recent head 81690ec. Consider uploading reports for the commit 81690ec to get more accurate results

@@             Coverage Diff              @@
##             master    #4221      +/-   ##
============================================
- Coverage     16.93%   16.90%   -0.04%     
+ Complexity     1413     1412       -1     
============================================
  Files           589      589              
  Lines         25789    25838      +49     
  Branches       2397     2398       +1     
============================================
- Hits           4368     4367       -1     
- Misses        20985    21033      +48     
- Partials        436      438       +2
Impacted Files Coverage Δ
...he/eventmesh/common/protocol/http/HttpCommand.java 52.57% <0.00%> (-6.05%) ⬇️
...entmesh/common/protocol/http/HttpEventWrapper.java 0.00% <0.00%> (ø)
...che/eventmesh/common/protocol/tcp/codec/Codec.java 58.33% <ø> (ø)
...ventmesh/metrics/api/model/HttpSummaryMetrics.java 0.00% <0.00%> (ø)
.../eventmesh/protocol/http/HttpProtocolConstant.java 0.00% <ø> (ø)
...col/http/resolver/HttpRequestProtocolResolver.java 0.00% <0.00%> (ø)
...ain/java/org/apache/eventmesh/runtime/acl/Acl.java 0.00% <0.00%> (ø)
...che/eventmesh/runtime/boot/AbstractHTTPServer.java 1.06% <0.00%> (-0.07%) ⬇️
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.56% <0.00%> (-0.01%) ⬇️
.../runtime/core/protocol/grpc/retry/GrpcRetryer.java 0.00% <0.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xwm1992
xwm1992 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wqliang wqliang merged commit 1bd7e7c into apache:master Jul 13, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@wqliang
Merge pull request apache#4221 from lrhkobe/1.5.1-improve
4a8d359 
[ISSUE apache#4217 apache#4218 apache#4219 apache#4220]Some bug fixes and optimization in http protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wqliang wqliang wqliang approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@lrhkobe @wqliang @xwm1992