[ISSUE #4011] add kafkaConnector module #4180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2023 23:02
…kafka_source_sink # Conflicts: # eventmesh-connectors/eventmesh-connector-kafka/src/main/java/org/apache/eventmesh/connector/kafka/server/KafkaConnectServer.java # eventmesh-connectors/eventmesh-connector-kafka/src/main/java/org/apache/eventmesh/connector/kafka/sink/connector/KafkaSinkConnector.java # eventmesh-connectors/eventmesh-connector-kafka/src/main/java/org/apache/eventmesh/connector/kafka/source/connector/KafkaSourceConnector.java # eventmesh-connectors/eventmesh-connector-kafka/src/main/resources/server-config.yml # eventmesh-connectors/eventmesh-connector-kafka/src/main/resources/sink-config.yml # eventmesh-connectors/eventmesh-connector-kafka/src/main/resources/source-config.yml
epiao55
changed the title
Contributor
Author
|
@qqeasonchen @xwm1992 PTAL |
mxsm
reviewed
Jul 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #4180 +/- ##
============================================
+ Coverage 16.77% 16.92% +0.15%
+ Complexity 1415 1412 -3
============================================
Files 592 589 -3
Lines 26040 25789 -251
Branches 2400 2397 -3
============================================
- Hits 4367 4366 -1
+ Misses 21235 20986 -249
+ Partials 438 437 -1 see 51 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
I have fixed style @mxsm |
Contributor
Author
|
PTAL~ @xwm1992 |
xwm1992
previously approved these changes
Jul 7, 2023
Alonexc
approved these changes
Jul 7, 2023
mxsm
reviewed
Jul 7, 2023
Comment on lines
53
to
62
| public void init(Config config) throws Exception { | ||
| this.sourceConfig = (KafkaSourceConfig) config; | ||
| Properties props = new Properties(); | ||
| props.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, sourceConfig.getConnectorConfig().getBootstrapServers()); | ||
| props.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class); | ||
| props.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class); | ||
| props.put(ConsumerConfig.GROUP_ID_CONFIG, sourceConfig.getConnectorConfig().getGroupID()); | ||
| props.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, "false"); | ||
|
|
||
| this.kafkaConsumer = new KafkaConsumer<String, String>(props); |
Member
There was a problem hiding this comment.
How about add max.poll.records to KafkaConsumer?The exact numbers are placed in the configuration file.
Contributor
Author
There was a problem hiding this comment.
ok，i have added some defalut config for kafka connector
Alonexc
approved these changes
Jul 13, 2023
add default config for kafka sink and source
1 task
Contributor
Author
|
@xwm1992 please help trigger the build, tks |
mxsm
approved these changes
Jul 20, 2023
xwm1992
approved these changes
Jul 21, 2023
3 tasks
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
* [ISSUE apache#4011] add kafkaConnector module * [ISSUE apache#4011] add kafkaConnector module * [ISSUE apache#4011] fix codestyle * Fixes apache#4011. add default config for kafka sink and source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4011.
add kafkaConnector module, include sink and source