Skip to content

[ISSUE #4164]Fix EventMeshGrpcConsumer client subscribe topic error #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 4 commits into from
Jun 30, 2023
Merged

[ISSUE #4164]Fix EventMeshGrpcConsumer client subscribe topic error #4165

xwm1992 merged 4 commits into from
Jun 30, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Jun 29, 2023

Fixes #4164

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

  • Fix EventMeshGrpcConsumer client subscribe topic error
  • Rename some method of ServiceUtils class

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #4165 (69813b2) into master (4e5428b) will decrease coverage by 0.01%.
The diff coverage is 1.88%.

❗ Current head 69813b2 differs from pull request most recent head 165e12a. Consider uploading reports for the commit 165e12a to get more accurate results

@@             Coverage Diff              @@
##             master    #4165      +/-   ##
============================================
- Coverage     16.93%   16.92%   -0.01%     
  Complexity     1412     1412              
============================================
  Files           589      589              
  Lines         25787    25789       +2     
  Branches       2397     2397              
============================================
  Hits           4366     4366              
- Misses        20984    20986       +2     
  Partials        437      437
Impacted Files Coverage Δ
...essor/AbstractPublishBatchCloudEventProcessor.java 0.00% <0.00%> (ø)
.../processor/AbstractPublishCloudEventProcessor.java 0.00% <0.00%> (ø)
...rpc/processor/BatchPublishCloudEventProcessor.java 0.00% <0.00%> (ø)
...re/protocol/grpc/processor/HeartbeatProcessor.java 0.00% <0.00%> (ø)
...ol/grpc/processor/PublishCloudEventsProcessor.java 0.00% <0.00%> (ø)
...protocol/grpc/processor/ReplyMessageProcessor.java 0.00% <0.00%> (ø)
...col/grpc/processor/RequestCloudEventProcessor.java 0.00% <0.00%> (ø)
...re/protocol/grpc/processor/SubscribeProcessor.java 0.00% <0.00%> (ø)
...tocol/grpc/processor/SubscribeStreamProcessor.java 0.00% <0.00%> (ø)
.../protocol/grpc/processor/UnsubscribeProcessor.java 0.00% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit 525a8dd into apache:master Jun 30, 2023
@mxsm mxsm deleted the eventmesh-4164 branch June 30, 2023 08:49
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@mxsm
[ISSUE apache#4164]Fix EventMeshGrpcConsumer client subscribe topic e…
86e2134 
…rror (apache#4165)

* [ISSUE apache#4164]Fix EventMeshGrpcConsumer client subscribe topic error

* fix code style

* fix code style

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@lrhkobe lrhkobe lrhkobe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] EventMeshGrpcConsumer client subscribe topic error

3 participants

@mxsm @xwm1992 @lrhkobe