Skip to content

[ISSUE #4161]Fix JsonUtils not support serialize java.time.LocalDate #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 2 commits into from
Jun 29, 2023
Merged

[ISSUE #4161]Fix JsonUtils not support serialize java.time.LocalDate #4162

xwm1992 merged 2 commits into from
Jun 29, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Jun 28, 2023

Fixes #4161

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Fix JsonUtils not support serialize java.time.LocalDate

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

TheR1sing3un
TheR1sing3un approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #4162 (bcce099) into master (35c1eb4) will increase coverage by 0.00%.
The diff coverage is 5.88%.

❗ Current head bcce099 differs from pull request most recent head b076e9e. Consider uploading reports for the commit b076e9e to get more accurate results

@@            Coverage Diff            @@
##             master    #4162   +/-   ##
=========================================
  Coverage     16.93%   16.93%           
  Complexity     1413     1413           
=========================================
  Files           589      589           
  Lines         25784    25787    +3     
  Branches       2397     2397           
=========================================
+ Hits           4367     4368    +1     
- Misses        20981    20983    +2     
  Partials        436      436
Impacted Files Coverage Δ
.../admin/handler/ShowListenClientByTopicHandler.java 12.90% <0.00%> (ø)
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% <0.00%> (ø)
...time/core/protocol/tcp/client/session/Session.java 2.34% <0.00%> (-0.06%) ⬇️
...a/org/apache/eventmesh/common/utils/JsonUtils.java 35.89% <100.00%> (+1.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lrhkobe
lrhkobe approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@lrhkobe lrhkobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 2258c21 into apache:master Jun 29, 2023
@mxsm mxsm deleted the eventmesh-4161 branch June 29, 2023 07:41
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@mxsm
[ISSUE apache#4161]Fix JsonUtils not support serialize java.time.Loca…
f540640 
…lDate (apache#4162)

* [ISSUE apache#4161]Fix JsonUtils not support serialize java.time.LocalDate

* fix codestyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@lrhkobe lrhkobe lrhkobe approved these changes

@Alonexc Alonexc Alonexc approved these changes

+1 more reviewer

@TheR1sing3un TheR1sing3un TheR1sing3un approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] JsonUtils not support serialize java.time.LocalDate

5 participants

@mxsm @xwm1992 @lrhkobe @TheR1sing3un @Alonexc