Skip to content

[ISSUE #4060]Use AbstractRetryer to unify GrpcRetryer, HttpRetryer and EventMeshTcpRetryer #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 2 commits into from
Sep 22, 2023
Merged

[ISSUE #4060]Use AbstractRetryer to unify GrpcRetryer, HttpRetryer and EventMeshTcpRetryer #4061

xwm1992 merged 2 commits into from
Sep 22, 2023

Conversation

@pandaapo
Copy link
Member

@pandaapo pandaapo commented Jun 1, 2023

Fixes #4060.

Motivation

GrpcRetryer, HttpRetryer and EventMeshTcpRetryer all have these method pushRetry(), init(), shutdown() and start(). Althougth parameter type in pushRetry() is different. But the types here are in inheritance relationship.

And there are similar logic in size() and getRetrys().

Modifications

Add an parent class for GrpcRetryer, HttpRetryer and EventMeshTcpRetryer.
Do some related modifications.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@pandaapo pandaapo changed the title *[ISSUE #4060]Use AbstractRetryer to unify GrpcRetryer, HttpRetryer and EventMeshTcpRetryer [ISSUE #4060]Use AbstractRetryer to unify GrpcRetryer, HttpRetryer and EventMeshTcpRetryer Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #4061 (e886f78) into master (74f9abf) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head e886f78 differs from pull request most recent head 7f72d53. Consider uploading reports for the commit 7f72d53 to get more accurate results

@@             Coverage Diff              @@
##             master    #4061      +/-   ##
============================================
+ Coverage     15.95%   15.98%   +0.02%     
  Complexity     1475     1475              
============================================
  Files           689      690       +1     
  Lines         27531    27482      -49     
  Branches       2570     2567       -3     
============================================
  Hits           4392     4392              
+ Misses        22691    22642      -49     
  Partials        448      448
Files Changed Coverage Δ
...entmesh/runtime/core/protocol/AbstractRetryer.java 0.00% <0.00%> (ø)
.../runtime/core/protocol/grpc/retry/GrpcRetryer.java 0.00% <0.00%> (ø)
.../runtime/core/protocol/http/retry/HttpRetryer.java 0.00% <0.00%> (ø)
.../tcp/client/session/retry/EventMeshTcpRetryer.java 0.00% <0.00%> (ø)
...esh/runtime/metrics/grpc/EventMeshGrpcMonitor.java 0.00% <0.00%> (ø)
...ntmesh/runtime/metrics/http/HTTPMetricsServer.java 2.02% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Pil0tXia Pil0tXia mentioned this pull request Aug 22, 2023
Merged
@pandaapo pandaapo mentioned this pull request Sep 14, 2023
Closed
@xwm1992 xwm1992 merged commit 08fabd2 into apache:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@lrhkobe lrhkobe lrhkobe approved these changes

@Alonexc Alonexc Alonexc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Use AbstractRetryer to unify GrpcRetryer, HttpRetryer and EventMeshTcpRetryer

4 participants

@pandaapo @xwm1992 @lrhkobe @Alonexc