Skip to content

[ISSUE #3870]Specifying the initial capacity of Map can save resources #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroccyen merged 1 commit into from
May 9, 2023
Merged

[ISSUE #3870]Specifying the initial capacity of Map can save resources #3871

mroccyen merged 1 commit into from
May 9, 2023

Conversation

@pandaapo
Copy link
Member

@pandaapo pandaapo commented May 5, 2023

Fixes #3870.

Motivation

When we can estimate the size of Map, specifying the initialization size is better.

Modifications

Specify the initialization size.

Documentation

  • Does this pull request introduce a new feature? no

Alonexc
Alonexc approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #3871 (6820b7c) into master (c5b7cf4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 6820b7c differs from pull request most recent head 7c50766. Consider uploading reports for the commit 7c50766 to get more accurate results

@@             Coverage Diff              @@
##             master    #3871      +/-   ##
============================================
- Coverage     13.81%   13.81%   -0.01%     
  Complexity     1291     1291              
============================================
  Files           571      571              
  Lines         29090    29091       +1     
  Branches       2841     2840       -1     
============================================
  Hits           4019     4019              
- Misses        24698    24699       +1     
  Partials        373      373
Impacted Files Coverage Δ
...esh/registry/etcd/service/EtcdRegistryService.java 19.68% <0.00%> (-0.16%) ⬇️
...e/core/protocol/grpc/consumer/ConsumerManager.java 0.00% <0.00%> (ø)
...l/grpc/processor/BatchPublishMessageProcessor.java 0.00% <0.00%> (ø)
...tocol/http/processor/SendSyncMessageProcessor.java 0.00% <0.00%> (ø)
...che/eventmesh/trace/zipkin/ZipkinTraceService.java 56.57% <0.00%> (+1.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

mroccyen
mroccyen approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@mroccyen mroccyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroccyen mroccyen merged commit c65a860 into apache:master May 9, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@mroccyen
Merge pull request apache#3871 from pandaapo/master-issue3870
fed2fe2 
[ISSUE apache#3870]Specifying the initial capacity of Map can save resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm approved these changes

@mroccyen mroccyen mroccyen approved these changes

@Alonexc Alonexc Alonexc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Specifying the initial capacity of Map can save resources

4 participants

@pandaapo @mxsm @mroccyen @Alonexc