[ISSUE #3485]Optimize Grpc protocol for Java #3746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@xwm1992 PTAL! |
mxsm
force-pushed
the
eventmesh-grpc-optimize-3485
branch
from
b3dee43 to
82800b0
Compare
xwm1992
requested changes
Jun 7, 2023
| .addService(new ProducerService(this, sendMsgExecutor)) | ||
| .addService(new ConsumerService(this, clientMgmtExecutor, replyMsgExecutor)) | ||
| .addService(new HeartbeatService(this, clientMgmtExecutor)) | ||
| .addService(new PublisherService(this, clientMgmtExecutor)) |
Contributor
There was a problem hiding this comment.
why publisherService use the clientMgmtExecutor?
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| @Slf4j | ||
| public abstract class AbstructPublishBatchCloudEventProcessor implements PublishProcessor<CloudEventBatch, CloudEvent> { |
Contributor
There was a problem hiding this comment.
Class Name Abstruct -> Abstract
Contributor
|
@mxsm please solve the conflicts. |
Member
Author
|
@xwm1992 I will fix it later |
mxsm
force-pushed
the
eventmesh-grpc-optimize-3485
branch
from
3c34547 to
e8116f2
Compare
Member
Author
|
@xwm1992 I have removed the useless class. |
Codecov Report
@@ Coverage Diff @@
## master #3746 +/- ##
============================================
+ Coverage 14.29% 16.91% +2.61%
- Complexity 1326 1410 +84
============================================
Files 581 588 +7
Lines 28667 25743 -2924
Branches 2793 2376 -417
============================================
+ Hits 4099 4355 +256
+ Misses 24180 20954 -3226
- Partials 388 434 +46
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
Jun 12, 2023
lrhkobe
approved these changes
Jun 12, 2023
kyooosukedn
pushed a commit
to kyooosukedn/eventmesh
that referenced
this pull request
Jun 18, 2023
* add cloudevent proto file * generate cloudevents java class * develop cloudevents for sdk * upgrade cloudevents version to 2.4.2 * develop cloudevents for runtime module * add test case * fix test case * fix test case * optimize logic * remove custom simplemessage class
This was referenced Nov 19, 2023
Closed
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
* add cloudevent proto file * generate cloudevents java class * develop cloudevents for sdk * upgrade cloudevents version to 2.4.2 * develop cloudevents for runtime module * add test case * fix test case * fix test case * optimize logic * remove custom simplemessage class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3485
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Added EventMesh's CloudEvents protocol to replace the SimpleMessage protocol.
The SimpleMessage protocol is temporarily not removed and the code is still present in the project. It will be removed in the future.
The protocol has been replaced in the SDK and runtime modules.
Documentation