Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Apr 1, 2023

Fixes #3595

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Fix Throw StorageResourceServiceKnativeImpl StorageResourceServiceKnativeImpl when start runtime with start.sh

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

…eResourceServiceKnativeImpl when start runtime with start.sh
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #3596 (c50aa2d) into master (228cc82) will decrease coverage by 0.86%.
The diff coverage is 7.69%.

❗ Current head c50aa2d differs from pull request most recent head 8426b5e. Consider uploading reports for the commit 8426b5e to get more accurate results

@@             Coverage Diff              @@
##             master    #3596      +/-   ##
============================================
- Coverage     14.62%   13.76%   -0.86%     
+ Complexity     1526     1292     -234     
============================================
  Files           651      571      -80     
  Lines         31713    29238    -2475     
  Branches       3032     2886     -146     
============================================
- Hits           4638     4026     -612     
+ Misses        26659    24839    -1820     
+ Partials        416      373      -43     
Impacted Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 85.71% <ø> (ø)
.../eventmesh/common/enums/EventMeshProtocolType.java 0.00% <0.00%> (ø)
...ventmesh/common/protocol/tcp/EventMeshMessage.java 0.00% <0.00%> (ø)
...rotocol/workflow/protos/EventmeshWorkflowGrpc.java 0.00% <ø> (ø)
.../org/apache/eventmesh/common/EventMeshMessage.java 35.29% <100.00%> (+3.71%) ⬆️

... and 240 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm changed the title [ISSUE #3595]Fix tThrow StorageResourceServiceKnativeImpl StorageResourceServiceKnativeImpl when start runtime with start.sh [ISSUE #3595]Fix throw StorageResourceServiceKnativeImpl StorageResourceServiceKnativeImpl when start runtime with start.sh Apr 2, 2023
@mytang0 mytang0 merged commit 697d729 into apache:master Apr 2, 2023
@mxsm mxsm deleted the eventmesh-3595 branch April 2, 2023 04:11
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
[ISSUE apache#3595]Fix throw StorageResourceServiceKnativeImpl StorageResourceServiceKnativeImpl when start runtime with start.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Throw StorageResourceServiceKnativeImpl StorageResourceServiceKnativeImpl when start runtime with start.sh

2 participants