Skip to content

Conversation

@PickBas
Copy link
Contributor

@PickBas PickBas commented Mar 5, 2023

Fixes #3234.

Modifications

Replaced lambda with method reference for aclBuilder

Documentation

  • Does this pull request introduce a new feature? (no)

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #3345 (4cf0b19) into master (a5b5613) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 4cf0b19 differs from pull request most recent head 5724ce3. Consider uploading reports for the commit 5724ce3 to get more accurate results

@@            Coverage Diff            @@
##             master    #3345   +/-   ##
=========================================
  Coverage     13.44%   13.44%           
  Complexity     1301     1301           
=========================================
  Files           588      588           
  Lines         30141    30141           
  Branches       2972     2972           
=========================================
  Hits           4053     4053           
  Misses        25732    25732           
  Partials        356      356           
Impacted Files Coverage Δ
...ain/java/org/apache/eventmesh/runtime/acl/Acl.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 52ae73f into apache:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Method reference could be replaced with lambda

4 participants