[ISSUE #3343]Optimize Codec.Encoder and Codec.Decoder #3344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3344 +/- ##
============================================
+ Coverage 13.04% 13.05% +0.01%
- Complexity 1191 1192 +1
============================================
Files 550 550
Lines 28700 28708 +8
Branches 2850 2850
============================================
+ Hits 3743 3747 +4
- Misses 24632 24636 +4
Partials 325 325
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
@lrhkobe please help review this pr. |
xwm1992
requested changes
Mar 8, 2023
| int bodyLength = ArrayUtils.getLength(bodyData); | ||
|
|
||
| int length = 4 + 4 + headerLength + bodyLength; | ||
| int length = headerLength + bodyLength; |
Contributor
There was a problem hiding this comment.
this line need to change:
int length = CONSTANT_MAGIC_FLAG.length + VERSION.length + headerLength + bodyLength;
| final int length = in.readInt(); | ||
| final int headerLength = in.readInt(); | ||
| final int bodyLength = length - 8 - headerLength; | ||
| final int bodyLength = length - headerLength; |
Contributor
There was a problem hiding this comment.
this line need to change:
final int bodyLength = length - CONSTANT_MAGIC_FLAG.length - VERSION.length - headerLength;
Member
Author
|
@xwm1992 done, PTAL~ |
xwm1992
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3343
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Optimize Codec.Encoder and Codec.Decoder
Documentation