Skip to content

[ISSUE #3341]Remove EventMeshTcpConnectionHandler.connections keyword static #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 1 commit into from
Mar 13, 2023
Merged

[ISSUE #3341]Remove EventMeshTcpConnectionHandler.connections keyword static #3342

xwm1992 merged 1 commit into from
Mar 13, 2023

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Mar 5, 2023 •
edited
Loading

Fixes #3341

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Remove EventMeshTcpConnectionHandler.connections keyword static

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mxsm mxsm force-pushed the eventmesh-3341 branch from c9fab6b to 40eea8b Compare March 5, 2023 04:42
@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited
Loading

Codecov Report

Merging #3342 (8c53eb1) into master (94562e9) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 8c53eb1 differs from pull request most recent head 40eea8b. Consider uploading reports for the commit 40eea8b to get more accurate results

@@            Coverage Diff            @@
##             master    #3342   +/-   ##
=========================================
  Coverage     13.04%   13.04%           
  Complexity     1191     1191           
=========================================
  Files           550      550           
  Lines         28700    28700           
  Branches       2850     2850           
=========================================
  Hits           3743     3743           
  Misses        24632    24632           
  Partials        325      325
Impacted Files Coverage Δ
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.57% <0.00%> (+<0.01%) ⬆️
...ocol/tcp/client/EventMeshTcpConnectionHandler.java 0.00% <0.00%> (ø)
...tmesh/runtime/metrics/tcp/EventMeshTcpMonitor.java 2.46% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit 8aa97ac into apache:master Mar 13, 2023
@mxsm mxsm deleted the eventmesh-3341 branch March 13, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove EventMeshTcpConnectionHandler.connections keyword static

2 participants

@mxsm @xwm1992